Closed
Bug 1715387
Opened 3 years ago
Closed 3 years ago
Need to flush style if GetOrBuildPathForMeasuring() is called from WebIDL
Categories
(Core :: SVG, enhancement, P3)
Core
SVG
Tracking
()
RESOLVED
FIXED
97 Branch
| Tracking | Status | |
|---|---|---|
| firefox97 | --- | fixed |
People
(Reporter: boris, Assigned: boris)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Bug 1340422 makes d attribute as a presentation attribute, so we get the svg path from style. However, we have to make sure we flush the style if the API is called from WebIDL. For example, SVGPathElement::GetOrBuildPathForMeasuring() may be called from internal or WebIDL, so we have to make sure we flush the style well from the caller if necessary. Also, we may have to add some tests to make sure it works properly.
See https://phabricator.services.mozilla.com/D115566#inline-649699 for more detail.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → boris.chiou
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•3 years ago
|
||
In order to make sure these APIs work properly, we have to flush style before
building the path to make sure the d property is up-to-date.
- isPointInFill()
- isPointInStroke()
- getTotalLength()
- getPointAtLength()
- getPathSegAtLength() (note: Legacy API, only Gecko and WebKit support.)
Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/72adcadcd2fd
Flush style properly for DOM APIs which use d property. r=jwatt,hiro,emilio
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox97:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 97 Branch
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/32054 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
You need to log in
before you can comment on or make changes to this bug.
Description
•