Closed Bug 1715512 Opened 3 years ago Closed 3 years ago

Move property information from shapes to property maps

Categories

(Core :: JavaScript Engine, task, P3)

Product:
Core
Component:
JavaScript Engine
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(21 files)

Bug 1715512 part 1 - Add TenuredCellWithFlags. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 2 - Add PropMap GC thing. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 3 - Add SMDOC comment for property maps. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 4 - Add (Shared)PropMapAndIndex tagged pointer type. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 5 - Add GetObjectFlagsForNewProperty overload that takes JSClass and ObjectFlags instead of shape. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 6 - Prepare PropertyInfo for property maps. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 7 - Add PropertyKey::isVoid. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 8 - Add more property map code. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 9 - Implement operations for shared maps. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 10 - Implement operations for dictionary maps. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 11 - Add fast path for sealing/freezing properties. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 12 - Add memory reporting for property maps. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 13 - Add heuristics for converting a shared map with many properties to a dictionary map. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 14 - Change shapes to be based on property maps. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 15 - Fix tests. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 16 - Rename inDictionary to isDictionary. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 17 - Add PropMap::dump and fix Shape::dump. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 18 - Implement NativeObject::checkShapeConsistency. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 19 - Remove now-unused JSID_EMPTY. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 20 - Rename Shape to PropMap in a few places. r?jonco!
(deleted), text/x-phabricator-request
Details
Bug 1715512 part 21 - Rename memory reporter for tree shapes to shared shapes. r?jonco!
(deleted), text/x-phabricator-request
Details

See bug 1704430.

Filing this as separate bug because there's more work to do after this part lands.

Depends on D117301

Depends on D117302

This will for example be used in the PropMapTable which maps from PropertyKey to
map + index.

Depends on D117303

The overload taking a shape will be removed in a later patch.

Depends on D117304

Mpas will store an array of PropertyInfos, add a private constructor to make
that work.

Also add a CompactPropertyInfo type that occupies two bytes instead of four. This
will be used for compact maps.

Depends on D117305

Depends on D117306

This adds most of the layout code and basic operations. Subsequent patches will
implement methods for mutating maps.

Depends on D117307

Depends on D117308

This corresponds to the fast path we currently have in SetIntegrityLevel, but
makes it more of a core operation.

The old Shape-based implementation doesn't support dictionary objects, but this
patch adds code for dictionary maps because it's easy to implement and is much
faster than the generic seal/freeze code.

Depends on D117310

Depends on D117311

This will replace what we currently have in ShouldConvertToDictionary.
The HadElementsAccess object flag we currently use there will be removed
in a later patch.

Depends on D117312

This is mostly removing code that's now implemented in property maps:

45 files changed, 1469 insertions(+), 2932 deletions(-)

See also the new SMDOC comment in Shape.h

In CacheIR.cpp remove the previous shape check. This is no longer necessary
after this code got rewritten a while ago.

Depends on D117313

The jit-test was creating objects with dense elements. Change this to use a
non-numeric property name.

The devtools test was failing because shapes no longer show up in the visible part
of the memory allocation table (it's more down the list because there are fewer
shapes). Use PropMap instead.

Depends on D117314

Also rename the IN_DICTIONARY flag to IS_DICTIONARY.

Shapes are no longer "part of" a dictionary list.

Depends on D117315

Depends on D117316

Depends on D117318

Also add a SWEEP_PROP_MAP phase because SWEEP_SHAPE still has other uses.

Depends on D117319

Shapes no longer form a tree.

Depends on D117320

Keywords: leave-open
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be3cce91c2ea part 1 - Add TenuredCellWithFlags. r=jonco https://hg.mozilla.org/integration/autoland/rev/fd06a92d7dca part 2 - Add PropMap GC thing. r=jonco https://hg.mozilla.org/integration/autoland/rev/384413c51058 part 3 - Add SMDOC comment for property maps. r=jonco https://hg.mozilla.org/integration/autoland/rev/afc818c6239f part 4 - Add (Shared)PropMapAndIndex tagged pointer type. r=jonco https://hg.mozilla.org/integration/autoland/rev/3f72d711cb8e part 5 - Add GetObjectFlagsForNewProperty overload that takes JSClass and ObjectFlags instead of shape. r=jonco https://hg.mozilla.org/integration/autoland/rev/a891a6588180 part 6 - Prepare PropertyInfo for property maps. r=jonco https://hg.mozilla.org/integration/autoland/rev/1b079a0a9674 part 7 - Add PropertyKey::isVoid. r=jonco https://hg.mozilla.org/integration/autoland/rev/4e9ac24171fc part 8 - Add more property map code. r=jonco https://hg.mozilla.org/integration/autoland/rev/3cd630145cbe part 9 - Implement operations for shared maps. r=jonco https://hg.mozilla.org/integration/autoland/rev/262d59c1f079 part 10 - Implement operations for dictionary maps. r=jonco https://hg.mozilla.org/integration/autoland/rev/42d02f0c0c49 part 11 - Add fast path for sealing/freezing properties. r=jonco https://hg.mozilla.org/integration/autoland/rev/b78abd24ecc6 part 12 - Add memory reporting for property maps. r=jonco https://hg.mozilla.org/integration/autoland/rev/01be02fe5a41 part 13 - Add heuristics for converting a shared map with many properties to a dictionary map. r=jonco
Keywords: leave-open
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/701a2c0f6706 part 14 - Change shapes to be based on property maps. r=jonco https://hg.mozilla.org/integration/autoland/rev/5b1e0b26ed64 part 15 - Fix tests. r=jonco https://hg.mozilla.org/integration/autoland/rev/5a58688c3bdf part 16 - Rename inDictionary to isDictionary. r=jonco https://hg.mozilla.org/integration/autoland/rev/3cf4b32dd4c9 part 17 - Add PropMap::dump and fix Shape::dump. r=jonco https://hg.mozilla.org/integration/autoland/rev/06d244d45354 part 18 - Implement NativeObject::checkShapeConsistency. r=jonco https://hg.mozilla.org/integration/autoland/rev/372a12f1d72f part 19 - Remove now-unused JSID_EMPTY. r=jonco https://hg.mozilla.org/integration/autoland/rev/d54b4b9f3e64 part 20 - Rename Shape to PropMap in a few places. r=jonco https://hg.mozilla.org/integration/autoland/rev/b6290ce477dc part 21 - Rename memory reporter for tree shapes to shared shapes. r=jonco

== Change summary for alert #30437 (as of Tue, 22 Jun 2021 10:36:33 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
6% JS macosx1015-64-shippable-qr 90,328,506.81 -> 85,305,639.95
5% JS linux1804-64-shippable-qr 88,365,054.60 -> 83,825,931.98
5% JS macosx1015-64-shippable 91,238,111.79 -> 86,617,203.39
5% JS windows10-64-shippable 89,238,429.68 -> 85,148,835.48
5% JS windows10-64-shippable-qr 89,314,457.27 -> 85,261,739.40
... ... ... ... ... ...
4% Base Content JS linux1804-64-shippable-qr 2,253,376.67 -> 2,173,972.67

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30437

Regressions: 1717405

== Change summary for alert #30503 (as of Thu, 01 Jul 2021 11:59:02 GMT) ==

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
2% outlook loadtime macosx1015-64-shippable-qr warm webrender 291.98 -> 285.54
1% outlook loadtime macosx1015-64-shippable-qr warm webrender 291.65 -> 287.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=30503

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: