Closed Bug 1715514 Opened 3 years ago Closed 3 years ago

Many comments about when stackmaps are created are wrong or misleading

Categories

(Core :: JavaScript: WebAssembly, defect, P3)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- fixed

People

(Reporter: lth, Assigned: lth)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1628426 changed the code so that stack maps are always created for debugging. Comments in the code that assert that stack maps are only created when there are reference types present are therefore wrong.

(I'm still undecided on whether the original change was correct but it's at least possible to track the broken comments on the present bug.)

Keywords: regression
Regressed by: 1628426
Has Regression Range: --- → yes

(In reply to Lars T Hansen [:lth] from comment #0)

(I'm still undecided on whether the original change was correct ...)

It is probably desirable to keep it the way it is now, see bug 1714086 comment 14. I'll fix the comments.

Update comments so that they adhere to the current reality: that every
function with a DebugFrame gets stack maps at all safe points
regardless of whether the function has reftyped values or locals.
(Whether it should be so is open to question, but it is so.)

Improve the description strings in the breakpoint traps.

Uniformly convert 'stack map' to 'stackmap' in comments so that we
have only one spelling throughout.

Pushed by lhansen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/659d78eb483c Fix sundry comments related to stackmaps and breakpoints. r=jseward
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: