Fix WebGL in combination with compositor integration
Categories
(Core :: Graphics: WebRender, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox91 | --- | fixed |
People
(Reporter: rmader, Assigned: rmader)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
It's currently broken for some reason.
Assignee | ||
Comment 1•3 years ago
|
||
Glenn, do have any idea if there's something special going on in WR wrt WebGL? I thought this already worked, but apparently doesn't. Do contents get blit somewhere, or do we somehow try to directly import WebGL buffers into a tile or so?
Assignee | ||
Comment 2•3 years ago
|
||
Never mind, apparently just a bug in the clipping logic in NativeLayerRootWayland
:)
Assignee | ||
Comment 3•3 years ago
|
||
So the issue here is that WebGL content apparently is treated Y-flipped within WR:
- the transformation matrix is either flipped or just transformed by the height of the layer, not sure yet
- content is y-flipped
Unfortunately RenderCompositorNative
does not let us know about it - and I don't yet understand how NativeLayerCA
figures this out. Glenn, does this ring any bell for you, that WebGL apparently gets treated differently in WR concerning coordinates / y-flipp?
Assignee | ||
Comment 4•3 years ago
|
||
Never mind and sorry for the noise! Stupid me just didn't handle y-flips in the transform matrix
Assignee | ||
Comment 5•3 years ago
|
||
This caused e.g. WebGL content to get hidden as it always fell out
of bounds. As a side effect clean up the whole custom transform math.
Depends on D118274
Updated•3 years ago
|
Assignee | ||
Comment 6•3 years ago
|
||
Pushed by robert.mader@posteo.de: https://hg.mozilla.org/integration/autoland/rev/e12a4e3c04b9 Handle Y-flipped transform matrices, r=gfx-reviewers,lsalzman
Comment 8•3 years ago
|
||
bugherder |
Description
•