Closed Bug 1716462 Opened 3 years ago Closed 3 years ago

Minor cleanups and improvements for KDE in nsLookAndFeel

Categories

(Core :: Widget: Gtk, enhancement)

Product:
Core
Component:
Widget: Gtk
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(3 files)

Bug 1716462 - Minor WidgetStyleCache cleanup. r=stransky
(deleted), text/x-phabricator-request
Details
Bug 1716462 - Add a bit more logging. r=stransky
(deleted), text/x-phabricator-request
Details
Bug 1716462 - Set right theme name when switching to Adwaita Dark. r=stransky
(deleted), text/x-phabricator-request
Details
No description provided.

We always support these functions, so no need to use dlsym. The csd type
technically depends on the theme I think, so caching it globally is
wrong. Instead compute it once and pass it down to the two callers that
care about it.

And reuse an already-computed name rather than calling GetGtkTheme
again.

Depends on D117722

This causes the right toolbar icons to get loaded on KDE, and should be
equivalent otherwise.

"gtk-application-prefer-dark-theme" is available since gtk 3.0, so seems
like we can use it safely.

Depends on D117723

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/42abdfd99cb4 Minor WidgetStyleCache cleanup. r=stransky https://hg.mozilla.org/integration/autoland/rev/da9c8170a934 Add a bit more logging. r=stransky
Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a866c17e623 Minor WidgetStyleCache cleanup. r=stransky https://hg.mozilla.org/integration/autoland/rev/fbffee420f6e Add a bit more logging. r=stransky

Need to tweak the last patch.

Keywords: leave-open
Attachment #9226964 - Attachment description: Bug 1716462 - Set Adwaita + gtk-application-prefer-dark-theme to get the dark version of Adwaita. r=stransky → Bug 1716462 - Set right theme name when switching to Adwaita Dark. r=stransky
Keywords: leave-open
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/961effac70fe Set right theme name when switching to Adwaita Dark. r=stransky

https://hg.mozilla.org/mozilla-central/rev/961effac70fe

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: