Closed Bug 1716506 Opened 3 years ago Closed 3 years ago

14.95% sessionrestore (Linux) regression on Thu June 10 2021

Categories

(Core :: Widget: Gtk, defect)

Product:
Core
Component:
Widget: Gtk
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox91 --- wontfix

People

(Reporter: Bebe, Unassigned)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a talos performance regression from push 0e6c67113ca7dba2de8101156993c563da62a3a1. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
34% ts_paint ts_paint linux1804-64-shippable-qr e10s stylo webrender-sw 215.33 -> 287.75
32% ts_paint_webext ts_paint_webext linux1804-64-shippable e10s stylo 214.00 -> 281.75
31% ts_paint ts_paint linux1804-64-shippable e10s stylo 211.08 -> 276.50
28% ts_paint_webext ts_paint_webext linux1804-64-shippable-qr e10s stylo webrender-sw 223.00 -> 285.42
28% ts_paint ts_paint linux1804-64-shippable-qr e10s stylo webrender 249.50 -> 318.75
23% ts_paint_webext ts_paint_webext linux1804-64-shippable-qr e10s stylo webrender 259.92 -> 319.33
15% sessionrestore_no_auto_restore sessionrestore_no_auto_restore linux1804-64-shippable-qr e10s stylo webrender 555.42 -> 640.58
15% sessionrestore sessionrestore linux1804-64-shippable-qr e10s stylo webrender 512.33 -> 588.92
15% sessionrestore sessionrestore linux1804-64-shippable-qr e10s stylo webrender-sw 470.33 -> 540.00
14% sessionrestore sessionrestore linux1804-64-shippable-qr e10s stylo webrender 500.92 -> 573.00
... ... ... ... ... ...
11% startup_about_home_paint startup_about_home_paint linux1804-64-shippable-qr e10s stylo webrender-sw 630.83 -> 699.42
11% startup_about_home_paint startup_about_home_paint linux1804-64-shippable-qr e10s stylo webrender 671.00 -> 742.58
9% startup_about_home_paint startup_about_home_paint linux1804-64-shippable e10s stylo 634.75 -> 694.42
9% startup_about_home_paint_realworld_webextensions startup_about_home_paint_realworld_webextensions linux1804-64-shippable-qr e10s stylo webrender 691.42 -> 753.00
8% startup_about_home_paint_realworld_webextensions startup_about_home_paint_realworld_webextensions linux1804-64-shippable e10s stylo 647.33 -> 700.00

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(emilio)

As mentioned in the commit message this is an expected startup regression, due to the loading of two GTK themes instead of one (which is what happenned for dark theme users before my patch already).

I don't think there's too much we can do to mitigate this actually, we kinda need the two color schemes, and we can't easily load them lazily since they're exposed to front-end CSS among other things...

Flags: needinfo?(emilio)

wontfix per comment 1.

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: affected → wontfix
Resolution: --- → WONTFIX
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.