Closed Bug 1716660 Opened 3 years ago Closed 3 years ago

Update content spacing in about:welcome

Categories

(Firefox :: Messaging System, enhancement, P1)

Firefox 91
enhancement

Tracking

()

VERIFIED FIXED
92 Branch
Iteration:
92.1 - Jul 12 - Jul 25
Tracking Status
firefox91 --- wontfix
firefox92 --- verified

People

(Reporter: emcminn, Assigned: emcminn)

References

Details

(Whiteboard: [proton-onboarding][priority:2a])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1714617 +++

Followup on discussions with UX. I'm moving some changes that were initially part of bug 1714617 to this bug, since adjusting the spacing/positioning of content (particularly for the Import screen of about:welcome) was introducing some new problems.

Updated figma here: https://www.figma.com/file/0awIRES0ZvRJ1U89fYPXjQ/MR1-Onboarding?node-id=3054%3A55251

Some relevant comments on this patch: https://phabricator.services.mozilla.com/D117047

Assignee: nobody → emcminn
Status: NEW → ASSIGNED
Attachment #9228623 - Attachment description: WIP: Bug 1716660 - Improve spacing around text items on import screen of about:welcome → Bug 1716660 - Improve spacing around text items on import screen of about:welcome
Attachment #9228623 - Attachment description: Bug 1716660 - Improve spacing around text items on import screen of about:welcome → WIP: Bug 1716660 - Improve spacing around text items on import screen of about:welcome
Attachment #9228623 - Attachment description: WIP: Bug 1716660 - Improve spacing around text items on import screen of about:welcome → Bug 1716660 - Improve spacing around text items on import screen of about:welcome
Iteration: 91.2 - Jun 14 - Jun 27 → 91.3 - Jun 28 - Jul 11
Priority: P2 → P1
Depends on: 1712802
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6044d864a425 Improve spacing around text items on import screen of about:welcome r=pdahiya
Iteration: 91.3 - Jun 28 - Jul 11 → 92.1 - Jul 12 - Jul 25
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

I have verified the following using Firefox Nightly 92.0a1 (Build ID: 20210718212857) on Windows 10 x64, macOS 11.4, and Ubuntu Linux 20.04 x64.

  • The "margin-bottom" of the "welcome-text" section is set to 20px and it remains set through different window resizes.
  • The "main-component" max-width remains set to 467px and the max-height remains set to 420px through different window resizes.
  • The primary and secondary buttons are closer to the section subtitle.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: