Closed Bug 1717031 Opened 3 years ago Closed 3 years ago

The devtools panel doesn't seem to pick up changes made with about:profiling

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
defect

Tracking

(firefox94 fixed)

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: julienw, Assigned: julienw)

References

Details

Attachments

(6 files)

Bug 1717031 - [devtools performance] Apply prettier on the gecko type file r=jdescottes!
(deleted), text/x-phabricator-request
Details
Bug 1717031 - [devtools performance] Wrap all recording settings in only one object in the Redux state r=jdescottes!
(deleted), text/x-phabricator-request
Details
Bug 1717031 - [devtools performance] Move all the preference and settings handling to a React component r=jdescottes!
(deleted), text/x-phabricator-request
Details
Bug 1717031 - [devtools performance] Observe profiler preferences to mirror them to the redux state r=jdescottes!
(deleted), text/x-phabricator-request
Details
Bug 1717031 - [devtools performance] Add a test that checks interactions between our various interfaces r=jdescottes!
(deleted), text/x-phabricator-request
Details
Bug 1717031 - [devtools performance] Fix missing bold style for the interval value label r=jdescottes!
(deleted), text/x-phabricator-request
Details

STR:

  1. Open the devtools performance panel (make sure this is the new one, enabled in the Devtools settings).
  2. Change to the "Custom" preset and click on "Edit settings".
  3. Change some values (threads, features)
  4. Look at the devtools panel again

=> The new features should be displayed, and especially, when starting the profiler and capturing a profile, the threads and features should be used (we can see that in the "meta panel" in the profiler UI).

Probably we should observe the preference and update the redux state when they change.

Julien, can you set a priority and severity for this bug? Thanks!

Flags: needinfo?(felash)
Severity: -- → S3
Flags: needinfo?(felash)
Priority: -- → P2
Blocks: 1668219
Blocks: 1693316
No longer blocks: 1668219
Assignee: nobody → felash

This also removes the previous abstraction about setting and getting
preferences, coming from a time where we would use remote preferences.
This is not needed anymore nowadays.

Depends on D123667

Attachment #9238031 - Attachment description: WIP: Bug 1717031 - Apply prettier on the gecko type file → Bug 1717031 - [devtools performance] Apply prettier on the gecko type file r=jdescottes!
Attachment #9238032 - Attachment description: WIP: Bug 1717031 - Wrap all recording settings in only one object in the Redux state → Bug 1717031 - [devtools performance] Wrap all recording settings in only one object in the Redux state r=jdescottes!
Attachment #9238033 - Attachment description: WIP: Bug 1717031 - Move all the preference and settings handling to a React component → Bug 1717031 - [devtools performance] Move all the preference and settings handling to a React component r=jdescottes!
Attachment #9238034 - Attachment description: WIP: Bug 1717031 - Observe profiler preferences to mirror them to the redux state → Bug 1717031 - [devtools performance] Observe profiler preferences to mirror them to the redux state r=jdescottes!

This is a typo from when we changed all l10n ids to start with "perftools"
instead of "perf". This class name was changed by mistake.

Depends on D124364

Pushed by jwajsberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a7b52ca035a1 [devtools performance] Apply prettier on the gecko type file r=jdescottes https://hg.mozilla.org/integration/autoland/rev/3b4da69bc322 [devtools performance] Wrap all recording settings in only one object in the Redux state r=jdescottes https://hg.mozilla.org/integration/autoland/rev/9a453a00cafe [devtools performance] Move all the preference and settings handling to a React component r=jdescottes https://hg.mozilla.org/integration/autoland/rev/4384ded09de9 [devtools performance] Observe profiler preferences to mirror them to the redux state r=jdescottes https://hg.mozilla.org/integration/autoland/rev/cfeedb916532 [devtools performance] Add a test that checks interactions between our various interfaces r=jdescottes https://hg.mozilla.org/integration/autoland/rev/8ee84b578fc5 [devtools performance] Fix missing bold style for the interval value label r=jdescottes
Regressions: 1729428
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: