Open Bug 1717511 Opened 3 years ago Updated 3 years ago

Clean up UnifiedComplete/UrlbarProviderPlaces

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
5

Tracking

()

People

(Reporter: bugzilla, Unassigned)

References

(Blocks 1 open bug)

Details

After the dust settles from converting UnifiedComplete into UrlbarProviderPlaces (bug 1717509), we should clean up UrlbarProviderPlaces. Non-exhaustive list of tasks:

  • UnifiedComplete currently has some code that performs a similar role as the muxer. Namely, deduping results in _getInsertIndexForMatch. We should move that functionality to the muxer and remove UnifiedComplete's system of "match keys" if possible.
  • Remove now-unused code paths in UnifiedComplete. This includes unused methods that weren't caught by lint because they're private, like _addSearchEngineMatch.
You need to log in before you can comment on or make changes to this bug.