Closed
Bug 1717749
Opened 3 years ago
Closed 3 years ago
Drop `MOZ_ASSERT` check for `nsIEditor.eEditorMailMask`
Categories
(Core :: DOM: Editor, defect, P1)
Tracking
()
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox89 | --- | unaffected |
| firefox90 | --- | unaffected |
| firefox91 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
In my understanding at fixing bug 1717156, nsIEditor.eEditorMailMask won't be set to TextEditor instance. However for making consistent spellchecker behavior on email composer, subject editor is also set this flag. So, we need to drop the check in Init and IsMailEditor.
|
Assignee | |
Comment 1•3 years ago
|
||
Oops, not Init, SetFlags.
|
|
Assignee | |
Comment 2•3 years ago
|
||
In my understanding at fixing bug 1717156, nsIEditor.eEditorMailMask won't be
set to TextEditor instance. However for making consistent spellchecker
behavior on email composer, subject editor is also set this flag. So, we need
to drop the check in SetFlags and IsMailEditor.
|
||
Updated•3 years ago
|
Keywords: regression
|
|
||
Comment 3•3 years ago
|
||
Set release status flags based on info from the regressing bug 1717156
status-firefox89:
--- → unaffected
status-firefox90:
--- → unaffected
status-firefox91:
--- → affected
status-firefox-esr78:
--- → unaffected
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/25696837f503
Drop `MOZ_ASSERT` check for `nsIEditor.eEditorMailMask` r=m_kato
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•