Closed
Bug 1718192
Opened 3 years ago
Closed 3 years ago
Land various cleanup related to bfcache navigation support
Categories
(DevTools :: Framework, task)
DevTools
Framework
Tracking
(firefox91 fixed)
RESOLVED
FIXED
91 Branch
| Tracking | Status | |
|---|---|---|
| firefox91 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(5 files)
Bug 1713607 starts to grow with a long list of patches made of preliminary cleanup which can be landed beforehand.
This include test fixes, new tests, and various tweaks that are obvious and can be landed right away. For the last patches of this queue, test coverage will only be possible once bfcache navigation actually work and will be covered by bug 1713607.
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
|
Assignee | |
Comment 4•3 years ago
|
||
This is a shortcut to avoid having to do descriptorFront.isProcessDescriptor && descriptorFront.isParent.
|
|
Assignee | |
Comment 5•3 years ago
|
||
- avoid unwatching DOCUMENT_EVENT in case of target-switching
- ensure emitting DevToolsFrameChild:destroy for all currently registered target actors
(didDestroy was clearing the list of actors used by _getTargetActorForWatcherActorID) - do not try to stop and restart server side watchers in case of bfcache navigation
|
|
Assignee | |
Comment 6•3 years ago
|
||
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5dbffbcf6c06 [devtools] Fix bfcache TargetCommand test against bfcache navigations. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/6d0c614aa68b [devtools] Cover target destruction events when doing bfcache navigations. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/727f24670ede [devtools] All server side targets follow the WindowGlobal lifecycle. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/e545e71c6b6f [devtools] Implements ProcessDescriptor.isParentProcessDescriptor. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/312cc80160cb [devtools] Fix various edgecase when doing BFCache navigation. r=nchevobbe
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5dbffbcf6c06
https://hg.mozilla.org/mozilla-central/rev/6d0c614aa68b
https://hg.mozilla.org/mozilla-central/rev/727f24670ede
https://hg.mozilla.org/mozilla-central/rev/e545e71c6b6f
https://hg.mozilla.org/mozilla-central/rev/312cc80160cb
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•