Rewrite nsMessageManagerScriptExecutor::LoadScriptInternal based on stencil
Categories
(Core :: JavaScript Engine, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
nsMessageManagerScriptExecutor::LoadScriptInternal uses 2 cache:
nsMessageManagerScriptHolderinnsMessageManagerScriptExecutor::sCachedScriptsScriptPreloader::GetCachedStencil, used fromTryCacheLoadAndCompileScript
After bug 1688788, ScriptPreloader uses stencil, and nsMessageManagerScriptExecutor::TryCacheLoadAndCompileScript is rewritten to use stencil for ScriptPreloader's cache.
We should rewrite nsMessageManagerScriptHolder also to use stencil, so that ExecuteInFrameScriptEnvironment and JS::CloneAndExecuteScript call in nsMessageManagerScriptExecutor::LoadScriptInternal can be removed.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
|
||
Comment 4•3 years ago
|
||
Backed out for causing leaks.
Backout link: https://hg.mozilla.org/integration/autoland/rev/67b1f53e79bbd755fb285606dcd246b5ae131295
Failure log: https://treeherder.mozilla.org/logviewer?job_id=351989321&repo=autoland&lineNumber=3022
|
||
Comment 5•3 years ago
|
||
Backout merged to central https://hg.mozilla.org/mozilla-central/rev/67b1f53e79bbd755fb285606dcd246b5ae131295
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Description
•