Closed Bug 1718204 Opened 3 years ago Closed 3 years ago

Ensure there's a content viewer in the in-process version of nsFrameLoader::PrintPreview.

Categories

(Toolkit :: Printing, defect)

Product:
Toolkit
Component:
Printing
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
92 Branch
Tracking Flags:
Tracking Status
firefox91 --- verified
firefox92 --- verified

People

(Reporter: emilio, Assigned: emilio)

References

Details

Crash Data

Attachments

(2 files)

Bug 1718204 - Ensure that there's a content viewer in the docshell we're cloning a document into. r=jwatt
(deleted), text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details
screencast issue.gif
(deleted), image/gif
Details
No description provided.

The code below assumes that, and bug 1666247 was hitting assertions
because of that, see D116877.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/92655507d670 Ensure that there's a content viewer in the docshell we're cloning a document into. r=jfkthame,layout-reviewers

https://hg.mozilla.org/mozilla-central/rev/92655507d670

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox92: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

Emilio, could you request an uplift of this? This fixes the parent process crash when Ctrl-P is used at about:support (bug 1720454 for STR).

Yes, I wanted to also request uplift of bug 1714639, but let's do this bug first, since it's harmless and it does fix the crash.

Comment on attachment 9228918 [details]
Bug 1718204 - Ensure that there's a content viewer in the docshell we're cloning a document into. r=jwatt

Beta/Release Uplift Approval Request

  • User impact if declined: Printing parent process pages crashes.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: go to about:support, Ctrl+P
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Simple fix for an invariant that was relied upon by a native API.
  • String changes made/needed: none
Attachment #9228918 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Crash Signature: [@ nsGlobalWindowOuter::Print]

Comment on attachment 9228918 [details]
Bug 1718204 - Ensure that there's a content viewer in the docshell we're cloning a document into. r=jwatt

Crash fix, approved for 91 beta 5, thanks.

Attachment #9228918 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]
Attached image screencast issue.gif (deleted) —

I've reproduced this issue with Fx 91.0b2 on Windows 10.
With the latest beta Fx 91.0b6, intermittently the print modal displays a blank image until the destination option is changed (see the attached screencast).

Flags: needinfo?(emilio)

Yeah, that's bug 1714639, which needs to be uplifted as well.

Flags: needinfo?(emilio)

Verified fixed with Fx 92.0a1 (2021-07-26) and Fx 91.0b8 (treeherder build) on Windows 10, macOS 11.0, Ubuntu 18.04

Status: RESOLVED → VERIFIED
status-firefox91: fixed → verified
status-firefox92: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: