Closed Bug 1718267 Opened 3 years ago Closed 3 years ago

18.33 - 2.68% fandom FirstVisualChange / wikia loadtime + 11 more (Linux) regression on Tue June 22 2021

Categories

(Core :: Networking: Cache, defect, P1)

defect

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox89 --- unaffected
firefox90 --- unaffected
firefox91 --- fixed
firefox92 --- fixed
firefox93 --- fixed
firefox94 --- fixed

People

(Reporter: Bebe, Assigned: valentin)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression, Whiteboard: [necko-triaged])

Attachments

(1 file)

Perfherder has detected a browsertime performance regression from push c7911efe7aad186df5f2737d9c7799c25e31afbd. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
18% fandom FirstVisualChange linux1804-64-shippable-qr warm webrender 200.00 -> 236.67
17% wikia FirstVisualChange linux1804-64-shippable-qr warm webrender 200.00 -> 233.33
9% fandom ContentfulSpeedIndex linux1804-64-shippable-qr warm webrender 259.67 -> 283.67
8% fandom ContentfulSpeedIndex linux1804-64-shippable-qr warm webrender 261.62 -> 282.50
7% wikia PerceptualSpeedIndex linux1804-64-shippable-qr warm webrender 333.71 -> 357.33
7% wikia ContentfulSpeedIndex linux1804-64-shippable-qr warm webrender 308.00 -> 329.58
6% wikia fnbpaint linux1804-64-shippable-qr warm webrender 206.88 -> 219.38
5% bing-search dcf linux1804-64-shippable-qr warm webrender 222.96 -> 234.79
5% wikia SpeedIndex linux1804-64-shippable-qr warm webrender 393.21 -> 413.00
5% fandom SpeedIndex linux1804-64-shippable-qr warm webrender 345.58 -> 362.25
5% fandom fnbpaint linux1804-64-shippable-qr warm webrender 204.98 -> 214.79
4% fandom dcf linux1804-64-shippable-qr warm webrender 365.79 -> 380.17
3% wikia loadtime linux1804-64-shippable-qr warm webrender 292.98 -> 300.83

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(valentin.gosu)

I'll be on vacation for a few weeks, so I can't investigate the cause right now.
Can we back it out and I'll try to reland it when I get back?
Thanks!

Flags: needinfo?(valentin.gosu)

Set release status flags based on info from the regressing bug 1708673

Fixed in 91 by the back out of bug 1708673 on the beta branch.

Jens, should we back out bug 1708673 on mozilla-central instead of backing it out of beta again in 93? Thanks!

Flags: needinfo?(jstutte)

Yes, that sounds reasonable.

Flags: needinfo?(jstutte) → needinfo?(pascalc)
Assignee: nobody → valentin.gosu
Priority: -- → P1
Whiteboard: [necko-triaged]
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0568cca2f4bb
Flip network.cache.bug1708673 to false to fix browsertime regression r=necko-reviewers,kershaw

Backed out for causing xpc failures in netwerk/test/unit/test_predictor

Backout link: https://hg.mozilla.org/integration/autoland/rev/96ba82d61a1693bed0db61d17bb116d9994e9e42

Push with failures

Failure log

Flags: needinfo?(valentin.gosu)
Flags: needinfo?(valentin.gosu)
Flags: needinfo?(pascalc)
Pushed by valentin.gosu@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/69b775e6026d
Flip network.cache.bug1708673 to false to fix browsertime regression r=necko-reviewers,kershaw
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: