Implement custom FBO management
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: rmader, Assigned: rmader)
References
(Blocks 2 open bugs, Regressed 1 open bug)
Details
Attachments
(2 files)
By reusing DMABufSurface we can manage FBOs ourselves instead of using the Wayland EGL platform, attaching buffer using zwp_linux_dmabuf_v1 directly. This has several advantages:
- we can get rid of the surface reordering workaround currently used when hiding surfaces in sync
- better partial damage support, similar to
NativeLayerCA::HandlePartialUpdateandWindowSurfaceWaylandMB::HandlePartialUpdate - more similar to other platforms like MacOS
- more control over GPU memory, fewer depth buffers
- clears the way for YUV support
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
In order to allow us to create FBOs ourselves. Right now only implement
it for DMABufSurfaceRGBA. In the future, we will want implement the same
for YUV, see bug 1711461.
|
||
Updated•3 years ago
|
Pushed by robert.mader@posteo.de: https://hg.mozilla.org/integration/autoland/rev/b0bd1ebf1329 Implement method to create a wl_buffer from a DMABufSurface, r=stransky
|
|
Assignee | |
Updated•3 years ago
|
Pushed by robert.mader@posteo.de: https://hg.mozilla.org/integration/autoland/rev/489ce763c140 Implement custom FBO management, r=jgilbert,gfx-reviewers
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
|
||
Comment 6•3 years ago
|
||
Backed out for causing wpt failures in /css/css-flexbox/flexbox-align-self-vert-001.xhtml
Backout link: https://hg.mozilla.org/integration/autoland/rev/425f0a769c49c13e046978f508310073e7f18807
|
|
||
Comment 7•3 years ago
|
||
@Robert, is it right to assume that only after patch in comment 4 is relanded and merged to central this bug can be consider as fixed?
|
|
Assignee | |
Comment 8•3 years ago
|
||
(In reply to Sandor Molnar from comment #7)
@Robert, is it right to assume that only after patch in comment 4 is relanded and merged to central this bug can be consider as fixed?
Right, thanks, the failure was caused by bug 1718570, so relanding this and updating bug 1718570 before landing.
Pushed by robert.mader@posteo.de: https://hg.mozilla.org/integration/autoland/rev/eb55f22378a0 Implement custom FBO management, r=jgilbert,gfx-reviewers
|
||
Comment 10•3 years ago
|
||
| bugherder | ||
Description
•