Closed Bug 1718670 Opened 3 years ago Closed 3 years ago

[XFA] Severe alignment issues

Categories

(Firefox :: PDF Viewer, defect, P1)

Product:
Firefox
Component:
PDF Viewer
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox90 --- disabled
firefox91 --- verified
firefox92 --- verified

People

(Reporter: danibodea, Assigned: calixte)

References

Details

Attachments

(5 files, 2 obsolete files)

poppler-973-0.pdf
(deleted), application/pdf
Details
severe allignment issues.png
(deleted), image/png
Details
Link to GitHub pull-request: https://github.com/mozilla/pdf.js/pull/13691
(deleted), text/x-github-pull-request
Details
Link to GitHub master push: https://github.com/mozilla/pdf.js/commit/36cfb15668a3d69a44d94ffb631535a5a04711fc
(deleted), text/x-github-pull-request
Details
alignment issue still present, but somewhat changed a bit.png
(deleted), image/png
Details
Attached file poppler-973-0.pdf (deleted) —

Note

  • When the user loads a specific PDF, he will notice the sevede allignment issues

Affected versions

  • Nightly v91.0a1

Affected platforms

  • all

Steps to reproduce

  1. Launch browser.
  2. Flip the pdfjs.enableXfa to true.
  3. Load the attached PDF file.

Expected result

  • The document is correctly displayed (as in Adobe Reader).

Actual result

  • Severe alignment issues and overlapping are being observed.

Regression range

  • This is not a regression.

Additional information:

Attached image severe allignment issues.png (deleted) —
Attached file poppler-18935-0.pdf (obsolete) (deleted) —

Severe alignment issues can also be observed on the following PDF file.

Attached image severe alignment issue pdf 2.png (obsolete) (deleted) —

Demo of PDF above.

Assignee: nobody → cdenizet
Status: NEW → ASSIGNED
Priority: -- → P1

The issues in the 2 pdfs are different here:

  • for the first one it's an issue due to nested containers with lr-tb layout: some container which should be on the next line are wrongly placed at the end of the current line.
  • for the second, I would say it's very likely a text layout issue: something is likely wrong with line heights

(In reply to Calixte Denizet (:calixte) from comment #4)

The issues in the 2 pdfs are different here:

  • for the first one it's an issue due to nested containers with lr-tb layout: some container which should be on the next line are wrongly placed at the end of the current line.
  • for the second, I would say it's very likely a text layout issue: something is likely wrong with line heights

Is your PR fixing the first? Can you open a separate bug for the second if they are separate issues?

Flags: needinfo?(cdenizet)
Commit merged into master by GitHub Authored by calixteman (calixteman)

Considering the information in comment 4, I have logged a separate issue for the second mentioned PDF: bug 1719844.
Furthermore, I will set the attachments reported in the other bug as obsolete in this one so there won't be any confusion.

Attachment #9229350 - Attachment is obsolete: true
Attachment #9229351 - Attachment is obsolete: true

After the latest fix, the rendering of this PDF file has changed slightly.
This is the updated rendering in Nightly v91.0a1 from 2021-07-09.

QA Whiteboard: [pdf_xfa_generic]
Depends on: 1720361
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

This issue is partially fixed as there are other alignment issues in the same PDF, but considering the fact that the reported demo area is in a decent enough form after the fix, I will close this bug as verified and open another for the remaining issue: bug 1720871.

Status: RESOLVED → VERIFIED
status-firefox92: --- → verified

Fixed in beta by the uplift in bug 1720361.

status-firefox91: affected → fixed
Flags: needinfo?(cdenizet)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: