Open Bug 1719161 Opened 3 years ago Updated 3 years ago

Empty topsites are missing borders on low zoom levels

Categories

(Firefox :: Top Sites, defect)

defect

Tracking

()

Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- fix-optional
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- wontfix
firefox92 --- fix-optional
firefox93 --- fix-optional

People

(Reporter: phorea, Unassigned)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Attached image 90%zoom (deleted) —

Affected versions

  • Firefox 89
  • Firefox 90 beta 12
  • latest Nightly 91.0a1 2021-07-05

Affected platforms

  • Win 10 64-bit
  • Ubuntu 18.04 64-bit
  • OSX 10.15

Steps to reproduce

  1. Open a new tab in Firefox - shortcuts/topsites are displayed under the search field
  2. Go to Personalize and select 2 or more rows for Shortcuts
  3. Decrease the zoom level to be under 90%

Expected result

  • Borders are visible no matter the zoom level

Actual result

  • Some topsites borders are not visible when decreasing the zoom level

Regression range

Amy, can you please take a look at this regression?

Thanks for flagging this! We are planning on removing the empty state entirely in the near future: https://bugzilla.mozilla.org/show_bug.cgi?id=1726446, so I think that makes this a wontfix.

Flags: needinfo?(achurchwell)
Has Regression Range: --- → yes

If you change the height of the input to 30px, then a 90% zoom works ok (because this is 27px), but a zoom of 75% not (because this is 22.50 px).

You can also avoid this by giving the border width of 3px. In this case, you will see that the width of the border is different in different places.

Anyway, the very best solution is to give more space around the inputs so that the border can be drawn cleanly even if it is in a subpixel position.
I had a similar problem, the border on the right side of the button was gone when zooming in/out. Adding the padding around the button fixed the border for me. https://theboic.com/product-category/sandpapers/ Thanks –
GraafM
Why doesn't it just round up to the nearest pixel? –
ESR
Hi @ESR, I want to implement this, but in my case, I have a dropdown that has 10 valves and after 5 I am using overflow: auto. In this case, I am not sure how can I give more padding at the bottom. The only bottom border is disappearing in my case.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: