Enable widget.macos.support-dark-appearance by default on Release
Categories
(Core :: Widget: Cocoa, task, P2)
Tracking
()
People
(Reporter: bugzilla, Assigned: bugzilla)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
[Tracking Requested - why for this release]:
This feature is currently enabled for Early Beta. This bug is just the pref-flip to enable it for Release. Product would like it in 91. There's only one more bug deemed blocking, which is bug 1710934. It's a small patch that's in review.
|
||
Updated•3 years ago
|
|
||
Comment 4•3 years ago
|
||
Backed out for causing browser-chrome failures in toolkit/components/extensions/test/browser/browser_ext_themes_highlight.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/0d1bbf9e767366b810abe835e6c5126dd7b0bc38
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
|
|
||
Comment 7•3 years ago
|
||
(In reply to Harry Twyford [:harry] from comment #2)
[Tracking Requested - why for this release]:
This feature is currently enabled for Early Beta. This bug is just the pref-flip to enable it for Release. Product would like it in 91. There's only one more bug deemed blocking, which is bug 1710934. It's a small patch that's in review.
Harry, is that still planned for 91 with an uplift to beta or will it ship with 92 train? Thanks
|
|
Assignee | |
Comment 8•3 years ago
|
||
Comment on attachment 9230342 [details]
Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r?#mac-reviewers
Beta/Release Uplift Approval Request
- User impact if declined: We want to ship this new feature in Firefox 91. macOS users will see improved dark mode support. It's already being tested on early Beta; this patch is just a pref flip that enables it on Release.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1710934
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Already tested on early beta with no regressions reported.
- String changes made/needed:
|
||
Comment 9•3 years ago
|
||
👏👏
|
|
||
Comment 10•3 years ago
|
||
Comment on attachment 9230342 [details]
Bug 1719734 - Enable widget.macos.support-dark-appearance by default on Release. r?#mac-reviewers
Uplift of a planned feature activation, approved for 91 beta 3, thanks.
|
|
||
Comment 11•3 years ago
|
||
| bugherder uplift | ||
Description
•