Closed Bug 1720315 Opened 3 years ago Closed 3 years ago

Perma esr91 OSX R-swr TEST-UNEXPECTED-PASS | image-element/element-paint-native-widget.html == image-element/element-paint-native-widget-ref.html | image comparison, max difference: 1, number of differing pixels: 5

Categories

(Core :: Layout: Images, Video, and HTML Frames, defect, P5)

defect

Tracking

()

RESOLVED FIXED
92 Branch
Tracking Status
firefox91 --- fixed
firefox92 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: jmaher)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

It looks (https://searchfox.org/mozilla-central/rev/699174544b058f13f02e7586b3c8fdbf438f084b/taskcluster/taskgraph/target_tasks.py#179) like the mac/windows debug builds only run on trunk, where the webrender-sw reftests pass, and esr, where they fail, but not beta or release, where they may have been failing for a while.

What's our way out for esr91? Turn off mac debug builds, turn off these webrender-sw reftests, something else?

in 2020 we turned off debug builds on beta/release as a cost saving measure. We took a calculated risk there and kept esr debug builds going for the primary reason that esr can get so far out of date from trunk.

some options:

  1. We can fix this in the esr91 source by adjusting the manifest.
  2. we can turn off debug osx reftests-swr
  3. we can turn off all debug osx tests

I am leaning towards #2, but #1 could be ok as well. I guess the question falls into why are we running -swr tests on osx/debug. My understanding is this is a fallback test for when we don't have the ability on the hardware/os/config for the end user to run webrender. Is this something we should worry about for ESR branch?

:aosmond, any thoughts from you?

Flags: needinfo?(jmaher) → needinfo?(aosmond)

I am going to do option #1

Flags: needinfo?(aosmond)
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/25d2ac7014c5 adjust fuzzy expectations of image-element/element-paint-native-widget.html to pass on esr91::osx/debug. r=releng-reviewers,bhearsum
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 92 Branch

Comment on attachment 9233375 [details]
Bug 1720315 - adjust fuzzy expectations of image-element/element-paint-native-widget.html to pass on esr91::osx/debug. r=#releng-reviewers

Beta/Release Uplift Approval Request

  • User impact if declined:
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): this is an issue we are seeing on esr91, and this fixes the issue.
  • String changes made/needed:
Attachment #9233375 - Flags: approval-mozilla-beta?

Comment on attachment 9233375 [details]
Bug 1720315 - adjust fuzzy expectations of image-element/element-paint-native-widget.html to pass on esr91::osx/debug. r=#releng-reviewers

Approved for 91 beta 9, thanks.

Attachment #9233375 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: