Perma esr91 OSX R-swr TEST-UNEXPECTED-PASS | image-element/element-paint-native-widget.html == image-element/element-paint-native-widget-ref.html | image comparison, max difference: 1, number of differing pixels: 5
Categories
(Core :: Layout: Images, Video, and HTML Frames, defect, P5)
Tracking
()
People
(Reporter: intermittent-bug-filer, Assigned: jmaher)
References
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details |
Filed by: csabou [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=345073560&repo=mozilla-esr91
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IiG7Sm_KREOl2Kw-3FBJDQ/runs/0/artifacts/public/logs/live_backing.log
Reftest URL: https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/IiG7Sm_KREOl2Kw-3FBJDQ/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1
Comment hidden (Intermittent Failures Robot) |
Comment 2•3 years ago
|
||
It looks (https://searchfox.org/mozilla-central/rev/699174544b058f13f02e7586b3c8fdbf438f084b/taskcluster/taskgraph/target_tasks.py#179) like the mac/windows debug builds only run on trunk, where the webrender-sw reftests pass, and esr, where they fail, but not beta or release, where they may have been failing for a while.
What's our way out for esr91? Turn off mac debug builds, turn off these webrender-sw reftests, something else?
Assignee | ||
Comment 3•3 years ago
|
||
in 2020 we turned off debug builds on beta/release as a cost saving measure. We took a calculated risk there and kept esr debug builds going for the primary reason that esr can get so far out of date from trunk.
some options:
- We can fix this in the esr91 source by adjusting the manifest.
- we can turn off debug osx reftests-swr
- we can turn off all debug osx tests
I am leaning towards #2, but #1 could be ok as well. I guess the question falls into why are we running -swr tests on osx/debug. My understanding is this is a fallback test for when we don't have the ability on the hardware/os/config for the end user to run webrender. Is this something we should worry about for ESR branch?
:aosmond, any thoughts from you?
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 6•3 years ago
|
||
Updated•3 years ago
|
Comment 8•3 years ago
|
||
bugherder |
Assignee | ||
Comment 9•3 years ago
|
||
Comment on attachment 9233375 [details]
Bug 1720315 - adjust fuzzy expectations of image-element/element-paint-native-widget.html to pass on esr91::osx/debug. r=#releng-reviewers
Beta/Release Uplift Approval Request
- User impact if declined:
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): this is an issue we are seeing on esr91, and this fixes the issue.
- String changes made/needed:
Comment 10•3 years ago
|
||
Comment on attachment 9233375 [details]
Bug 1720315 - adjust fuzzy expectations of image-element/element-paint-native-widget.html to pass on esr91::osx/debug. r=#releng-reviewers
Approved for 91 beta 9, thanks.
Comment 11•3 years ago
|
||
bugherder uplift |
Description
•