Closed Bug 1720835 Opened 3 years ago Closed 3 years ago

[Linux] New UI of bookmark toolbar popupmenu is misaligned

Categories

(Firefox :: Menus, defect)

Firefox 92
Desktop
Linux
defect

Tracking

()

VERIFIED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- unaffected
firefox91 --- unaffected
firefox92 --- verified
firefox93 --- verified

People

(Reporter: lilydjwg, Assigned: emmamalysz)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached image misalign.png (deleted) —

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:92.0) Gecko/20100101 Firefox/92.0

Steps to reproduce:

open a submenu of a bookmark folder on the bookmark toolbar

Actual results:

the submenu is misaligned (see screenshot)

(btw the items of new UI is much higher than old ones, making some of my bookmark folder need to scroll.)

Expected results:

They should align nicely.

Oh, it doesn't vertically aligned with the toolbar item well, either.

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Bookmarks & History

Can you test the issue while in Safe Mode? You can find helpful info here : https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode .
Also a fresh new profile could help. You can find more about creating a new profile here : https://support.mozilla.org/en-US/kb/troubleshoot-and-diagnose-firefox-problems#w_6-create-a-new-firefox-profile .
If possible, you can test this issue on the nightly build as well. Download the build from : https://www.mozilla.org/en-US/firefox/nightly/all/ .

Flags: needinfo?(lilydjwg)

Hi, it's already nightly + new profile. I just tried safe mode and it's the same.

Flags: needinfo?(lilydjwg)
Component: Bookmarks & History → Menus

Emma, this appears to be a regression from bug 1703051. Are you able to take a look?

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(emalysz)
OS: Unspecified → Linux
Regressed by: 1703051
Hardware: Unspecified → Desktop
Summary: New UI of bookmark toolbar popupmenu is misaligned → [Linux] New UI of bookmark toolbar popupmenu is misaligned
Has Regression Range: --- → yes
Assignee: nobody → emalysz
Attachment #9237840 - Attachment description: WIP: Bug 1720835: adjust top margin for menupopups in placestooolbar → Bug 1720835: adjust top margin for menupopups in placestooolbar
Status: NEW → ASSIGNED
Flags: needinfo?(emalysz)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Go ahead and nominate this for Beta approval when you get a chance.

Comment on attachment 9237840 [details]
Bug 1720835: adjust top margin for menupopups in placestooolbar

Beta/Release Uplift Approval Request

  • User impact if declined: Menupopus are misaligned on Linux
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: On Linux:
  1. Open the "other bookmarks" folder in the bookmarks toolbar
  2. Open a nested folder within "other bookmarks"
  3. Notice the menupopups are aligned
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): No string changes
  • String changes made/needed: n/a
Flags: needinfo?(emalysz)
Attachment #9237840 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9237840 [details]
Bug 1720835: adjust top margin for menupopups in placestooolbar

Approved for 92.0b9.

Attachment #9237840 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Reproduced the issue on Firefox beta 92.0b8 (20210824191834) build on Ubuntu 18.04.
Verified fixed on Firefox beta 92.0b9 (20210825224239) and Firefox Nightly 93.0a1 (2021-08-26) (20210826031555) on Ubuntu 18.04.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: