All Mac crashes - https://crash-stats.mozilla.org/signature/?signature=wr_moz2d_render_cb&date=%3E%3D2021-04-19T22%3A23%3A00.000Z&date=%3C2021-07-19T22%3A23%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#reports

Crash report: https://crash-stats.mozilla.org/report/index/15412a22-cf9b-41a3-b45c-9b2d80210719

MOZ_CRASH Reason: MOZ_RELEASE_ASSERT(false)

Top 10 frames of crashing thread:

0 XUL wr_moz2d_render_cb gfx/webrender_bindings/Moz2DImageRenderer.cpp:471
1 XUL webrender_bindings::moz2d_renderer::rasterize_blob gfx/webrender_bindings/src/moz2d_renderer.rs:659
2 XUL rayon::iter::plumbing::bridge_producer_consumer::helper third_party/rust/rayon/src/iter/plumbing/mod.rs:438
3 XUL rayon_core::join::join_context::{{closure}} third_party/rust/rayon-core/src/join/mod.rs:158
4 XUL rayon_core::registry::in_worker third_party/rust/rayon-core/src/registry.rs:879
5 XUL rayon::iter::plumbing::bridge_producer_consumer::helper third_party/rust/rayon/src/iter/plumbing/mod.rs:416
6 XUL <rayon_core::job::StackJob<L, F, R> as rayon_core::job::Job>::execute third_party/rust/rayon-core/src/job.rs:119
7 XUL rayon_core::registry::WorkerThread::wait_until_cold third_party/rust/rayon-core/src/registry.rs:730
8 XUL rayon_core::registry::ThreadBuilder::run third_party/rust/rayon-core/src/registry.rs:56
9 XUL std::sys_common::backtrace::__rust_begin_short_backtrace /builds/worker/fetches/rustc/lib/rustlib/src/rust/library/std/src/sys_common/backtrace.rs:125

A few Thunderbird crashes bp-f718d717-cd36-4938-afbf-179160210719
Actually ~ #4 crash for 90 and 91 beta - but they might not all be legit graphics crashes

Actually Linux and Mac https://crash-stats.mozilla.org/signature/?product=Thunderbird&release_channel=%21release&signature=wr_moz2d_render_cb&date=%3E%3D2021-08-09T02%3A00%3A00.000Z&date=%3C2021-08-23T02%3A00%3A00.000Z#summary

Actually ~ #4 crash for 90 and 91 beta - thought they might not all be legit graphics crashes

This has translated to becoming the #10 crash for version 91.

Currently the majority of the crashes are Thunderbird

And overwhelmingly those crashes are on Macs - 96% - and all versions of macOS - for example bp-a36ff521-f587-4ece-9ede-295ad0211028 bp-7067562f-1802-4d10-9ef3-110550211027

Does this shed some useful light on the problem?

In fact, this is the #1 crash for Macs using Thunderbird 91.2.1

Looks font related, in which case it should probably depend on bug 1738391

|[0][GFX1 39]: Failed to get ScaledFont entry for FontInstanceKey 3813 (t=3763.23) |[1][GFX1 39]: Failed to get ScaledFont entry for FontInstanceKey 3813 (t=3763.23) |[2][GFX1 39]: Failed to get ScaledFont entry for FontInstanceKey 3813 (t=3763.23) |[3][GFX1 39]: Failed to get ScaledFont entry for FontInstanceKey 3813 (t=3763.23) |[4][GFX1-]: Replay failure: FillGlyphs PLAY (t=3763.23) |[5][GFX1-]: Replay failure: FillGlyphs PLAY (t=3763.23) |[6][GFX1-]: Replay failure: FillGlyphs PLAY (t=3763.23) |[7][GFX1-]: Replay failure: FillGlyphs PLAY (t=3763.23)

Andew's going make us crash earlier.

I know I said I would but I am wondering what we hope to achieve. We can reasonably surmise this call is what is failing on the playback:

https://searchfox.org/mozilla-central/rev/9028b0458cc1f432870d2996b186b0938dda734a/gfx/2d/RecordedEventImpl.h#2399

because just before that, when we were adding ScaledFont entries to the table, we hit this:

https://searchfox.org/mozilla-central/rev/9028b0458cc1f432870d2996b186b0938dda734a/gfx/webrender_bindings/Moz2DImageRenderer.cpp#286

I wanted a separate signature for this crash.

Need to figure out why the font key is not in the table.

Just a few words from me. Firefox started crashing with this signature on my OPNsense dashboard every few seconds. Since it is reproducible easily I bisected this regression to this change:

2021-12-21T17:00:12.166000: DEBUG : Found commit message:
Bug 1742896 - Pass TextRunDrawParams to GetScaledFont. r=jfkthame

This tries to clean up some of the awkwardness from bug 1730772 so that we can
do further fixes more easily if necessary.

Differential Revision: https://phabricator.services.mozilla.com/D133353

Before that I haven't seen any crashes with this signature.

Kacper, what OS do you see this on?

(In reply to Jeff Muizelaar [:jrmuizel] from comment #10)

Kacper, what OS do you see this on?

Windows 10. I hit the same assertion mentioned before Failed to get ScaledFont entry for FontInstanceKey.

ni? to Lee in the hope he might have some ideas here.

This bug pre-dates the regressing bug from bug 1749103. In particular, this affects ESR as well when the other didn't. Where are we tracking the earlier crashes at this point if this was duped to a newer bug?

This bug can remain open for now since there are still instances of this signature that are divorced from/predate what caused bug 1749103.

(In reply to Jim Mathies [:jimm] from comment #4)

Looks font related, in which case it should probably depend on bug 1738391

Given that bug 1738391 is not able to move forward, is there another way to moved this bug forward?

I'm not sure - Lee?

I filed this originally against Mac, but it is interesting that Windows 10 and 11 crash counts are very low for both Firefox and Thunderbird compared to Windows 7.

Not sure whether this indicates anything, but Firefox's crash count ratio, release vs beta, is rougly 2:1 which seems extraordinary.

Barely exists in Thunderbird 102.

Firefox crashes end after 105.0.3
https://crash-stats.mozilla.org/signature/?version=%2191.13.1&product=Firefox&signature=wr_moz2d_render_cb&date=%3E%3D2022-06-17T13%3A06%3A00.000Z&date=%3C2022-12-17T13%3A06%3A00.000Z#summary

Not surprising, Thunderbird crashes continue for 102, at least through 102.5.1
https://crash-stats.mozilla.org/signature/?version=%2191.13.1&product=Thunderbird&signature=wr_moz2d_render_cb&date=%3E%3D2022-06-17T13%3A06%3A00.000Z&date=%3C2022-12-17T13%3A06%3A00.000Z#summary