Filed by: jcristau [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=345737350&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/E6P69GEFS7qPzygJFc5LMQ/runs/0/artifacts/public/logs/live_backing.log

The ESR macro should probably be called something else, it clashes with code in the windows sdk:

[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -  In file included from Unified_c_third_party_nICEr1.c:29:
[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-win32.c:18:
[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/um/iphlpapi.h:1122:
[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/shared/netioapi.h:146:
[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/shared/ntddndis.h:2822:
[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/shared/windot11.h:44:
[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -  /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/shared/WlanTypes.h(106,11): error: expected member name or ';' after declaration specifiers
[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -      UINT8 ESR;                               // Emergency Services Reachable
[task 2021-07-20T12:10:57.860Z] 12:10:57     INFO -      ~~~~~ ^
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  /builds/worker/workspace/obj-build/mozilla-config.h(29,13): note: expanded from macro 'ESR'
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  #define ESR 1
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -              ^
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  In file included from Unified_c_third_party_nICEr1.c:29:
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/dom/media/webrtc/transport/third_party/nICEr/src/stun/addrs-win32.c:18:
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/um/iphlpapi.h:1122:
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/shared/netioapi.h:146:
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/shared/ntddndis.h:2822:
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  In file included from /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/shared/windot11.h:44:
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  /builds/worker/checkouts/gecko/vs2017_15.8.4/SDK/include/10.0.17134.0/shared/WlanTypes.h(106,10): error: expected ';' at end of declaration list
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -      UINT8 ESR;                               // Emergency Services Reachable
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -           ^
[task 2021-07-20T12:10:57.861Z] 12:10:57     INFO -  2 errors generated.
[task 2021-07-20T12:10:57.861Z] 12:10:57    ERROR -  make[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:597: Unified_c_third_party_nICEr1.obj] Error 1

Changing the priority to p1 as the bug is tracked by a release manager for the current beta.
See What Do You Triage for more information

I think we can just remove the lines:

set_config("ESR", milestone.is_esr)
set_define("ESR", milestone.is_esr)

for now since they aren't used (yet). And I'll come up with new names for the defines in bug 1720389

That's fair. I was going for the rename option in https://hg.mozilla.org/try/rev/ca7b9b860bd91fc21e0ec33bc0217da572df4e16

Try build: https://treeherder.mozilla.org/jobs?repo=try&revision=002f401e4adce15f8c4e77f0160f98d3e4d1b28f

Let's rename to MOZ_ESR

The patch in bug 1720389 fixes this.

Mike, should we mark this bug as fixed and non-blocking esr 91 per comment #5 or is there more work to do in this bug? Thanks

Nope, we're good. Thanks!