Closed Bug 1722576 Opened 3 years ago Closed 3 years ago

Implement self.structuredClone()

Categories

(Core :: DOM: postMessage, enhancement)

Product:
Core
Component:
DOM: postMessage
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
94 Branch
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: d, Assigned: evilpie)

References

(Blocks 2 open bugs,
URL
)

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Bug 1722576 - Implement self.structuredClone(). r?baku,sfink
(deleted), text/x-phabricator-request
Details
Bug 1722576 - Rename PostMessageOptions to StructuredSerializeOptions. r?baku
(deleted), text/x-phabricator-request
Details
Bug 1722576 - Fix clang-tidy build error
(deleted), text/x-phabricator-request
Details
Blocks: html
Assignee: nobody → evilpies
Status: NEW → ASSIGNED

Steve, I was hoping you could take a look at this. Thanks.

Flags: needinfo?(sphink)
Flags: needinfo?(sphink)
Attachment #9235767 - Attachment description: WIP: Bug 1722576 - WIP: Implement self.structuredClone() → Bug 1722576 - Implement self.structuredClone(). r?baku,sfink
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4d0e3d6a1960 Implement self.structuredClone(). r=smaug,sfink,baku https://hg.mozilla.org/integration/autoland/rev/d31a1c199922 Rename PostMessageOptions to StructuredSerializeOptions. r=smaug

Backed out for causing wpt failures in structured-clone.any.worker.html

Backout link

Push with failures

Failure log

Flags: needinfo?(evilpies)

The destructor has an assertion for mTransferredPorts.IsEmpty(). As far as I can tell we aren't supposed to do anything with the transferred ports, so we can just work around that assertion.

Flags: needinfo?(evilpies)
Pushed by evilpies@gmail.com: https://hg.mozilla.org/integration/autoland/rev/f50502328881 Implement self.structuredClone(). r=smaug,sfink,baku https://hg.mozilla.org/integration/autoland/rev/b486e4108902 Rename PostMessageOptions to StructuredSerializeOptions. r=smaug
Attachment #9243456 - Attachment description: WIP: Bug 1722576 - Fix clang-tidy build error → Bug 1722576 - Fix clang-tidy build error

https://hg.mozilla.org/mozilla-central/rev/f50502328881
https://hg.mozilla.org/mozilla-central/rev/b486e4108902
https://hg.mozilla.org/mozilla-central/rev/aa67c5a8e93c

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch

Hey, it's great to see structuredClone() land in Firefox!

For the record, the failing WPT tests in html/webappapis/structured-clone/structured-clone.any.html are due to a bug I introduced in https://github.com/web-platform-tests/wpt/pull/30824, which was specific to the self.structuredClone() runner and worked fine with other uses of the structured clone algorithm. This is now being fixed in https://github.com/web-platform-tests/wpt/pull/31034.

Regressions: 1741182
Blocks: 1753860
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: