Closed Bug 1722582 Opened 3 years ago Closed 3 years ago

Bad CSS styling / download progress bar not visible on Linux

Categories

(Toolkit :: Places, defect, P2)

Firefox 92
defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox93 --- fixed

People

(Reporter: abspack, Assigned: emilio)

References

Details

Attachments

(2 files)

Attached image downloads.gif (deleted) —

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0

Steps to reproduce:

Start a download on Firefox under Linux. I tested multiple distros like KDE, Ubuntu and Xfce and all had the same problem.

Actual results:

The background color of the download items in the library window has the same color as the progress bar of the actively downloaded file.

Expected results:

The background color of the download items should have a different color as the progress bar of the actively downloaded file. Also if I unselect an item in the downloads list and move the window then the first item gets selected again but that should not happen. During window movement the selection color changes and the dotted outline is removed which is weird and should not happen too.

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Widget: Gtk
Product: Firefox → Core

Which Gtk theme do you use?

Flags: needinfo?(abspack)
Priority: -- → P2

I tested multiple themes and distros for example the Adwaita or Greybird theme. And I tested Ubuntu, Kubuntu, Xubuntu and so on. All have the same problem. I also tested this with the latest nightly (the image you see above is from nightly). Please make sure to also read the "Expected results" in my initial post because I also mention other bugs there which may be related.

Flags: needinfo?(abspack)

Emilio, any idea here?
Thanks.

Flags: needinfo?(emilio)

This is a front-end issue. The selected item background is here, and the progressbar background is here. They are indeed the same color (Highlight) and there's no border so it's indistinguishable.

Component: Widget: Gtk → Places
Product: Core → Toolkit

This looks fine on Windows and macOS as well, afaict, and fixes the bug.

Assignee: nobody → emilio
Flags: needinfo?(emilio)
Blocks: 1595052
Status: UNCONFIRMED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Depends on: 1710918

Bug 1710918 updated the progress bars to better match the Proton spec. That included reducing the height of both the bar itself and the tray it sits in to 4px. I also addressed the bar color in a selected item where the colors get reversed. So while my patch removed the changes this made, it should not have regressed anything.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: