Closed Bug 1723188 Opened 3 years ago Closed 2 years ago

about:preferences keeps the refresh driver ticking at 60Hz all the time

Categories

(Firefox :: Settings UI, defect, P1)

Product:
Firefox
Component:
Settings UI
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
105 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- wontfix
firefox-esr102 --- wontfix
firefox103 --- wontfix
firefox104 --- wontfix
firefox105 --- fixed

People

(Reporter: florian, Assigned: florian)

References

(Depends on 1 open bug, Blocks 1 open bug, Regression)

Details

(Keywords: perf, power, regression)

Attachments

(1 file)

Bug 1723188 - Hide hidden animated images in about:preferences using display: none in addition to visibility: hidden to avoid having them use CPU.
(deleted), text/x-phabricator-request
Details

This was introduced when bug 1689727 changed #updateDeck from a xul deck to a stack with the non-selected decks hidden using visiblity: hidden. The correct fix would be to fix bug 560067, but I'll provide a patch to add an easy workaround.

Profile showing the problem: https://share.firefox.dev/3iXPV52 (There's 4 "Image Animation" markers, and the RefreshDriverTick markers slow down only after about:preferences is closed)
Profile with the patch applied: https://share.firefox.dev/3y9QPC1 (There's only one "Image Animation" marker, and the refresh driver slows down after 1.4s at the end of the update check)

Severity: -- → S4
Priority: -- → P1
Has Regression Range: --- → yes

Sorry, there was a problem with the detection of inactive users. I'm reverting the change.

Assignee: nobody → florian
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05de372f854c Hide hidden animated images in about:preferences using display: none in addition to visibility: hidden to avoid having them use CPU. r=preferences-reviewers,jaws

https://hg.mozilla.org/mozilla-central/rev/05de372f854c

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox105: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 105 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: