Closed Bug 1723712 Opened 3 years ago Closed 2 years ago

Downloads created outside the "legacy" download saver have no referrer info which breaks the "go to download page" context menu

Categories

(Firefox :: Downloads Panel, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
98 Branch

People

(Reporter: Gijs, Assigned: aminomancer)

References

Details

(Whiteboard: [fidefe-Outreachy2021])

Attachments

(1 file)

Example steps:

  1. open https://xkcd.com/
  2. right click the comic, click "inspect" to open the inspector
  3. right click the node in the inspector, click "screenshot node
  4. open the downloads panel, right click the downloads entry
  5. click "go to download page.

ER:
it goes somewhere

AR:
nothing happens.

We should either disable the menu entry or fix the createDownload API to require referrer info and update all the consumers to provide some.

Severity: -- → S3
Priority: -- → P3
Whiteboard: [fidefe-Outreachy2021]
Flags: needinfo?(shmediaproductions)

The "Go To Download Page" menuitem in the downloads panel context menu
currently is always visible, even if the download is missing referrer
info. A download source should ideally always have referrer info,
but it's worth having a fallback so user doesn't see failures.
This patch also adds hiding for the "Copy Location" menuitem in the
unlikely event that a download is lacking a source or the source is
somehow lacking a URL. It implements a test to confirm hiding works.
I checked other downloads panel context menu tests to make sure they
aren't broken by the menuitems potentially being hidden.
This shouldn't close Bug 1723712 since we should ensure all downloads
have referrer info. This is just a stopgap in the meantime.

Assignee: nobody → shmediaproductions
Status: NEW → ASSIGNED
Keywords: leave-open
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/36365441c6c0 Disable downloads context menu items when inapplicable. r=Gijs

Did we just keep this open so we could add referrer info for all the download creators?

Flags: needinfo?(shughes)

it would be better to file a new bug anyway, than to keep bugs with landed patches open.

Flags: needinfo?(VYV03354)

I added leave-open because I read the last paragraph of comment #1.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Flags: needinfo?(VYV03354)
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch

Thanks, I missed that 😅 we can work on the referrer info issue in bug 1727292

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: