Closed Bug 1724296 Opened 3 years ago Closed 3 years ago

Enable many tests skipped for test-verify

Categories

(Testing :: General, task)

Product:
Testing
Component:
General
Version:
Default
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: gbrown, Assigned: gbrown)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

Bug 1724296 - Remove many skip-if(verify) test annotations (crashtests); r=
(deleted), text/x-phabricator-request
Details
Bug 1724296 - Remove many skip-if(verify) test annotations (reftest-plain); r=
(deleted), text/x-phabricator-request
Details
Bug 1724296 - Remove many skip-if(verify) test annotations (xpcshell); r=
(deleted), text/x-phabricator-request
Details
Bug 1724296 - Remove many skip-if(verify) test annotations (wpt); r=
(deleted), text/x-phabricator-request
Details
Bug 1724296 - Remove many skip-if(verify) test annotations (mochitest); r=
(deleted), text/x-phabricator-request
Details
Bug 1724296 - Remove many skip-if(verify) test annotations (mochitest pt 2); r=
(deleted), text/x-phabricator-request
Details

There are currently many (100s) test annotations for test-verify, like:

https://searchfox.org/mozilla-central/rev/74abde6afe26cfcaa6ecb3ebefc7a80a781550a7/browser/components/resistfingerprinting/test/mochitest/mochitest.ini#24

[test_speech_synthesis.html]
skip-if = verify

Many of these annotations were made in bug 1405428, in 2018.

However, when I check these tests today, I find many of them pass test-verify reliably. Let's review and update.

Assignee: nobody → whole.grains
Blocks: test-verify
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1405428
Keywords: leave-open
Pushed by whole.grains@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/f1ce2d999f58 Remove many skip-if(verify) test annotations (reftest-plain); r=jmaher https://hg.mozilla.org/integration/autoland/rev/a437c2600b5d Remove many skip-if(verify) test annotations (crashtests); r=jmaher https://hg.mozilla.org/integration/autoland/rev/e9a081e484e6 Remove many skip-if(verify) test annotations (xpcshell); r=jmaher,necko-reviewers
Pushed by whole.grains@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/4bdd44f7fa79 Remove many skip-if(verify) test annotations (wpt); r=jgraham
Pushed by whole.grains@protonmail.com: https://hg.mozilla.org/integration/autoland/rev/fa18593631bd Remove many skip-if(verify) test annotations (mochitest); r=jmaher

This completes the review of skip-if(verify) in mochitest.ini.

Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/658c01aa3522 Remove many skip-if(verify) test annotations (mochitest pt 2); r=jmaher

The leave-open keyword is there and there is no activity for 6 months.
:gbrown, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.

Flags: needinfo?(gbrown)

I hoped to make another pass through the manifests, and I think I never did do one type (browser.ini?). But I'm not finding time to properly finish up; maybe this is good enough?

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(gbrown)
Resolution: --- → FIXED
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: