Closed Bug 1724687 Opened 3 years ago Closed 2 years ago

Remove usage of OS.File from CDP implementation

Categories

(Remote Protocol :: CDP, task, P3)

task

Tracking

(firefox111 fixed)

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: whimboo, Assigned: barret, Mentored)

References

Details

(Whiteboard: [lang=js])

Attachments

(1 file)

Similar to bug 1723145, which removed the usage of OS.File for Marionette, we have to remove it from our partial CDP implementation:

https://searchfox.org/mozilla-central/search?q=OS.File&path=remote%2F&case=false&regexp=false

All the found instances need to be replaced by IOUtils and PathUtils. See the following commit to get an idea what needs to be done:

https://hg.mozilla.org/mozilla-central/rev/621e47647e8b

Hey! I think I can make the required changes.
But I am not able to figure out where to make changes in
https://searchfox.org/mozilla-central/source/remote/cdp/StreamRegistry.jsm#54
Can you please guide me through this?
Thank you

Kirti, I'm sorry for replying that late but due to some reason I haven't seen your comment. In the case you are still around and also still be interested to work on this bug please let me know. I'm more than happy to provide the necessary details to get you started. Sorry again.

Flags: needinfo?(kirti1211c)
Priority: -- → P3
Flags: needinfo?(kirti1211c)

This patch replaces the internals of the StreamRegistry et al to use
nsIStorageStream as the stream type. A storage stream is not directly readable,
so registry returns a stream and read handle (as a nsIBinaryInputStream) for
reading.

Assignee: nobody → brennie
Status: NEW → ASSIGNED
Duplicate of this bug: 1772727
Blocks: 1737308
Attachment #9306047 - Attachment description: Bug 1772727 - Remove osfile.jsm usage from remote/cdp r?whimboo!,nika! → Bug 1724687 - Remove osfile.jsm usage from remote/cdp r?whimboo!,nika!
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/631e22733b8b Remove osfile.jsm usage from remote/cdp r=webdriver-reviewers,nika,whimboo

Barret, I had a look at bug 1603739 and I can no longer reproduce the underlying issue and closed it. As such feel free to also remove the whole block for waiting until the PDF file has been completely written to disk. Thanks.

Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/11c0626c2b80 Remove osfile.jsm usage from remote/cdp r=webdriver-reviewers,nika,whimboo
Flags: needinfo?(brennie)
Pushed by brennie@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3523d141513d Remove osfile.jsm usage from remote/cdp r=webdriver-reviewers,nika,whimboo
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: