Remove usage of OS.File from CDP implementation
Categories
(Remote Protocol :: CDP, task, P3)
Tracking
(firefox111 fixed)
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: whimboo, Assigned: barret, Mentored)
References
Details
(Whiteboard: [lang=js])
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Similar to bug 1723145, which removed the usage of OS.File
for Marionette, we have to remove it from our partial CDP implementation:
https://searchfox.org/mozilla-central/search?q=OS.File&path=remote%2F&case=false®exp=false
All the found instances need to be replaced by IOUtils and PathUtils. See the following commit to get an idea what needs to be done:
Comment 1•3 years ago
|
||
Hey! I think I can make the required changes.
But I am not able to figure out where to make changes in
https://searchfox.org/mozilla-central/source/remote/cdp/StreamRegistry.jsm#54
Can you please guide me through this?
Thank you
Reporter | ||
Comment 2•3 years ago
|
||
Kirti, I'm sorry for replying that late but due to some reason I haven't seen your comment. In the case you are still around and also still be interested to work on this bug please let me know. I'm more than happy to provide the necessary details to get you started. Sorry again.
Reporter | ||
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
This patch replaces the internals of the StreamRegistry et al to use
nsIStorageStream as the stream type. A storage stream is not directly readable,
so registry returns a stream and read handle (as a nsIBinaryInputStream) for
reading.
Updated•2 years ago
|
Updated•2 years ago
|
Comment 6•2 years ago
|
||
Backed out for causing multiple failures
Backout link: https://hg.mozilla.org/integration/autoland/rev/2de5f759dac6e348cd5b8a3e20d96fa99bd42815
Reporter | ||
Comment 7•2 years ago
|
||
Barret, I had a look at bug 1603739 and I can no longer reproduce the underlying issue and closed it. As such feel free to also remove the whole block for waiting until the PDF file has been completely written to disk. Thanks.
Comment 9•2 years ago
|
||
Backed out for causing xpc failures in remote/cdp/test/xpcshell/test_StreamRegistry.js
Backout link: https://hg.mozilla.org/integration/autoland/rev/5b8107f660cf44deb159a9a0c9d9f1086e8db714
[Failure log xpc] (https://treeherder.mozilla.org/logviewer?job_id=402079526&repo=autoland&lineNumber=2489)
Assignee | ||
Updated•2 years ago
|
Comment 10•2 years ago
|
||
Comment 11•2 years ago
|
||
bugherder |
Description
•