Closed
Bug 1724781
Opened 3 years ago
Closed 3 years ago
Create a key system that will be used to configure the clearkey CDM for protection query tests
Categories
(Core :: Audio/Video: GMP, enhancement, P1)
Core
Audio/Video: GMP
Tracking
()
RESOLVED
FIXED
93 Branch
Tracking | Status | |
---|---|---|
firefox93 | --- | fixed |
People
(Reporter: bryce, Assigned: bryce)
References
Details
Attachments
(2 files)
- Add a pref to gate special clearkey key systems.
- Add a new key system that will be used to configure the clearkey CDM.
- Change Gecko code to handle the new key system (if the pref is set).
I do not plan to change the clearkey CDM in this bug, this bug is focused on the new key system and plumbing it. Following this, I'll rework the clearkey CDM to behave differently if it's created with the key system added here.
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
This allows us to use the EME_KEY_SYSTEM_CLEARKEY_WITH_PROTECTION_QUERY from JS.
This is done by changing the code in two places
- We consider the key system as clearkey in IsClearkeyKeySystem if it is preffed
on. This will allow our checks that take place as part of granting key system
access to pass. - We include the new key system in the tags supported by the clearkey CDM. This
means that when Gecko searches for a GMP that supports the new key system, the
clearkey GMP will be considered as a match. This functionality is not gated
by pref for two reasons: 1) the gating done elsewhere is sufficient to prevent
usage if the pref is not set, 2) the loading of GMPs is not re-done if we
toggle the pref, so if we gated this functionality behind a pref we'd need to
trigger some kind of reloading of GMPs when the pref is toggled.
Depends on D122143
Assignee | ||
Comment 3•3 years ago
|
||
This exposes a new key system behind a pref. The new key system doesn't do anything differently than clearkey yet.
Testing:
- Set
media.clearkey.test-key-systems.enabled
to true. - Navigate to this test page I've lovingly crafted.
- Enter
org.mozilla.clearkey_with_protection_query
in the text field and hit the button.
If the code works correctly then the video should play all the way through.
Pushed by bvandyk@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cee45dd2cfb9
Add org.mozilla.clearkey_with_protection_query keysystem to key system access code. r=alwu
https://hg.mozilla.org/integration/autoland/rev/9bc9be04ebbb
Treat EME_KEY_SYSTEM_CLEARKEY_WITH_PROTECTION_QUERY as a clearkey system if preffed on. r=alwu
Comment 5•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/cee45dd2cfb9
https://hg.mozilla.org/mozilla-central/rev/9bc9be04ebbb
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•