Closed
Bug 1724919
Opened 3 years ago
Closed 3 years ago
Move TypedObject allocation out of NewObject
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
93 Branch
| Tracking | Status | |
|---|---|---|
| firefox93 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(4 files)
Typed objects currently use the generic allocation path. It's simpler and faster to pull this out of there. We can then change the generic allocation path to only deal with native objects, which lets us remove a number of branches.
|
Assignee | |
Comment 1•3 years ago
|
||
Perf-sensitive code and this is actually a lot simpler for many of the callers.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Depends on D122231
|
|
Assignee | |
Comment 3•3 years ago
|
||
Depends on D122232
|
|
Assignee | |
Comment 4•3 years ago
|
||
Depends on D122233
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ce282254ee7
part 1 - Stop using Result<> in object allocation code. r=jonco
https://hg.mozilla.org/integration/autoland/rev/7893ce886183
part 2 - Stop using the generic object allocation path for typed objects. r=jonco
https://hg.mozilla.org/integration/autoland/rev/0f8022c5ac57
part 3 - Simplify NewObject* now that it's only used for native objects. r=jonco
https://hg.mozilla.org/integration/autoland/rev/3a8d3b625ac3
part 4 - Assert objects are allocated with a background AllocKind when possible. r=jonco
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/8ce282254ee7
https://hg.mozilla.org/mozilla-central/rev/7893ce886183
https://hg.mozilla.org/mozilla-central/rev/0f8022c5ac57
https://hg.mozilla.org/mozilla-central/rev/3a8d3b625ac3
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox93:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•