Closed Bug 1725305 Opened 3 years ago Closed 3 years ago

Wrong selector name of search setting button on urlbar

Categories

(Firefox :: Search, defect)

defect

Tracking

()

RESOLVED FIXED
93 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- fixed
firefox91 --- wontfix
firefox92 --- fixed
firefox93 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

When we introduced compact mode for search one-off component in bug 1709405, renamed the class name of search setting button as well. But, it seems that there was a part that we couldn't handle, the style of setting button on urlbar is not being applied correctly.
https://searchfox.org/mozilla-central/rev/170547001c81e7ec05f2855d8349b6b7e97c2658/browser/themes/shared/urlbarView.inc.css#663
In this bug, we fix it, apply the proper style.

Summary: Class name of search setting button on urlbar should be search-setting-button → Wrong selector name of search setting button on urlbar

Set release status flags based on info from the regressing bug 1709405

Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e46490e1ab4 Rename the selector for search setting button on urlbar r=desktop-theme-reviewers,harry
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Please nominate this for Beta & ESR91 approval when you get a chance.

Flags: needinfo?(daisuke)

Comment on attachment 9235906 [details]
Bug 1725305: Rename the selector for search setting button on urlbar

Beta/Release Uplift Approval Request

  • User impact if declined: Layout for search setting button on urlbar won’t be that we intended.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The change is only style and that is one line.
  • String changes made/needed: None
Flags: needinfo?(daisuke)
Attachment #9235906 - Flags: approval-mozilla-beta?

Comment on attachment 9235906 [details]
Bug 1725305: Rename the selector for search setting button on urlbar

Approved for 92.0b5 and 91.1esr.

Attachment #9235906 - Flags: approval-mozilla-esr91+
Attachment #9235906 - Flags: approval-mozilla-beta?
Attachment #9235906 - Flags: approval-mozilla-beta+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: