Closed Bug 1725576 Opened 3 years ago Closed 3 years ago

Spell check causing issues - hangs Thunderbird

Categories

(Thunderbird :: Message Compose Window, defect)

Thunderbird 92
x86_64
macOS
defect

Tracking

(thunderbird92 fixed)

RESOLVED DUPLICATE of bug 1721801
Tracking Status
thunderbird92 --- fixed

People

(Reporter: acdp, Unassigned)

References

Details

(Keywords: hang)

Attachments

(5 files)

Attached image Screenshot 2021-08-13 at 09.41.12.png (deleted) —

Spell Check opens (set to do so before send as default)
Now seems to be checking grammer (punctuation) as well.

Cleared the "highlighted" areas, recheck, fields now blank but Spell Check hangs TB, had to "force quit"

Image attached

Retried, still checks grammer, fine, but then when I select "ignore" Spell Check does not ckear the field

I note that there was a "similar" bug 518523 raised, 12 years ago, and revisited 7 months!

Attached image Screenshot 2021-08-13 at 09.56.24.png (deleted) —

see 2nd comment to bug

So even caused "freeze" when sending the details for the newbeta 92.0b1
see 2nd attachement

Attached image Error log for spell check freeze (deleted) —

so spell check froze messae again when sending report for the beta test!!!

Cleared the "highlighted" areas

I don't see the issue. But I also don't completely understand the steps. Please clarify what must be done, step by step.

Flags: needinfo?(acdp)

I don't normally have spell check on send enabled. (just SCAYT)
It mostly worked, until it didn't.

Probably bug 1721801

Status: NEW → RESOLVED
Closed: 3 years ago
Keywords: hang
Resolution: --- → DUPLICATE

Running macOS 10.14.6.
Here opening the spellcheck popup window and replacing a misspelled word crashes TB on closing the popup.
Crash reports:
bp-59ba2074-c736-42a2-9244-c683a0210813
bp-328e94d6-13ce-4061-8d62-9d4940210813
bp-da929b79-9fad-4ead-8e66-a6da10210813

The crashes are Bug 1722748 - Crash in [@ mozilla::TextServicesDocument::OffsetEntryArray::SplitElementAt] - a regression caused by Bug 1718924 - Make OffsetEntry in TextServicesDocument.cpp clearer.

I was able to cause the crash - but not on my first replace.

The patch didn't get make it for TB 92.0b1. But it is fixed on daily and should be fixed in 92.0b2 which will come early next week. Maybe will also fix the hang?

Flags: needinfo?(acdp)

(In reply to Wayne Mery (:wsmwk) from comment #7)

The crashes are Bug 1722748 - Crash in [@ mozilla::TextServicesDocument::OffsetEntryArray::SplitElementAt] - a regression caused by Bug 1718924 - Make OffsetEntry in TextServicesDocument.cpp clearer.

I was able to cause the crash - but not on my first replace.

The patch didn't get make it for TB 92.0b1. But it is fixed on daily and should be fixed in 92.0b2 which will come early next week. Maybe will also fix the hang?

Tested in 92.0b2 (build 1) - can be closed as resolved (for me at least) macOS 10.15.7 en-UK

NOT FIXED - edited a word in the "Replace with" field to "add word" - HANGS TB again! had to restart TB

was sending a reply to the 92.0b2 release test!!!!

Suspect the "Grammar" check component not working properly, can check and alter spelling, the action above was to check/edit/change Grammar noted "error"

The attached screenshot shows that the user has no dictionary installed. I received reports where installing a dictionary solved the issue. Could you check if this is the case for all of you who see this error?

It may be worthwhile to copy/backup the broken profile before installing the a dictionary, because I am not able to remove the default English dictionary and was never able to reproduce this myself.

NOT FIXED will send a recording of the issue when I can shrink it

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---

(In reply to John Bieling (:TbSync) from comment #11)

The attached screenshot shows that the user has no dictionary installed. I received reports where installing a dictionary solved the issue. Could you check if this is the case for all of you who see this error?

It may be worthwhile to copy/backup the broken profile before installing the a dictionary, because I am not able to remove the default English dictionary and was never able to reproduce this myself.

John - I will check this as am sure I have the UK dic installed...

Attached image Dic for En-UK installed! (deleted) —

(In reply to John Bieling (:TbSync) from comment #11)

The attached screenshot shows that the user has no dictionary installed. I received reports where installing a dictionary solved the issue. Could you check if this is the case for all of you who see this error?

It may be worthwhile to copy/backup the broken profile before installing the a dictionary, because I am not able to remove the default English dictionary and was never able to reproduce this myself.

Seems I have it installed as the screenshot shows...yes? or am I mistaken?

Attached video Spell check crash.mp4 (deleted) —

Thanks for the video. It looks like these are two different bugs. There is a bug related to missing dictionaries which has a patch now (and it affects add-ons causing emails to not being sent anymore), but the crash you observe seems to come from somewhere else.

92.0b3 seems to have fixed this issue - tested on macOS 10.15.7 en-UK

Agreed

Status: REOPENED → RESOLVED
Closed: 3 years ago3 years ago
Resolution: --- → DUPLICATE
Summary: Spell check causing issues → Spell check causing issues - hangs Thunderbird
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: