Include all possible vendored dependencies under "requirements.txt"
Categories
(Firefox Build System :: Mach Core, task)
Tracking
(firefox94 fixed)
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: mhentges, Assigned: mhentges)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 1 obsolete file)
A fair amount of the packages in third_party/python/
have been copied in there manually, causing two downsides:
- They aren't asserted to be compatible with each other
- It's not obvious what some of the versions of the packages are
We should port them to use the centralized system.
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 2•3 years ago
|
||
There's no usages of the pep487
module.
Depends on D123120
Assignee | ||
Comment 3•3 years ago
|
||
Note that, as part of adding this packages to the automated vendoring
system, some dependencies were automatically added - most notably,
dependencies of taskcluster
that become visible with Python 3.6+.
Adds **/.git
to the exclusions because:
.git
is part of our.hgignore
, but.git
is part of theaiohttp
tar.gz
file.
Since the file isn't needed for pip install
-ing aiohttp
,
and since we want ./mach vendor python
to be a no-op when there's
no requirement changes, we exclude it.
Depends on D123121
Assignee | ||
Comment 4•3 years ago
|
||
Depends on D123122
Assignee | ||
Comment 5•3 years ago
|
||
Rather than deleting the expected target directory of each package
that's being vendored, clear the whole third_party/python
directory
and re-populate it from scratch.
As part of this, there's an "exclusion" list for packages that can't
be vendored from PyPI.
This has some benefits:
- It'll be harder to forget scraps of files and directories and leave
them inthird_party/python
. - The exclusion list makes it more clear which packages are managed
manually, and the friction it adds to the workflow will guide
developers to use "requirements.in" instead.
The test_up_to_date_vendor
test will verify that the vendor directory
is always clean.
Depends on D123123
Updated•3 years ago
|
Comment 7•3 years ago
|
||
Backed out for causing invalid handle xpcshell failures.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=350477627&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/6b58b83b626e01f7b2af85156c293c9bccd82816
Comment 9•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/746509f3a640
https://hg.mozilla.org/mozilla-central/rev/06115f01c86f
https://hg.mozilla.org/mozilla-central/rev/dd841f22c83e
Description
•