Closed Bug 1726279 Opened 3 years ago Closed 3 years ago

Enable audioIPC IPC rework for Windows and Linux

Categories

(Core :: Audio/Video: cubeb, task)

task

Tracking

()

RESOLVED FIXED
98 Branch
Tracking Status
firefox98 --- fixed

People

(Reporter: kinetik, Assigned: kinetik)

References

(Regressed 2 open bugs)

Details

Attachments

(2 files, 1 obsolete file)

After landing bug 1726275 and an initial period of testing for macOS, enable for Windows and Linux.

Blocks: 1697845
Blocks: 1533220

Aiming for Firefox 98 to land this.

TODO:

  • Rename audioipc2 crates back to audioipc
  • Merge macos branch to master
  • Refresh WIP patch to include above
Target Milestone: --- → Future
Depends on: 1748160
Attachment #9255626 - Attachment is obsolete: true

The code removal will be done in bug https://bugzilla.mozilla.org/show_bug.cgi?id=1697845. This bug will track preffing on v2 for Windows/Linux by default once bug 1748160 lands.

Depends on: 1748515
Attachment #9257278 - Attachment description: WIP: Bug 1726279 - Enable AudioIPC rework for Windows and Linux by default. → Bug 1726279 - Enable AudioIPC rework for Windows and Linux by default. r?#cubeb-reviewers
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e0e816460df3 Enable AudioIPC rework for Windows and Linux by default. r=cubeb-reviewers,padenot
Backout by nfay@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/46d88977f644 Backed out changeset e0e816460df3 for causing dt failures on browser_devtools-presets.js

Backed out for causing dt failures on browser_devtools-interrupted.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/46d88977f64466c2eac059fa994ea4c16704f5fd

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=QE_fs7t7RYmz80CyK7y8xw.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e0e816460df3dafbdf076e72bb7c4125cd0b03c7

Failure log(s): https://treeherder.mozilla.org/logviewer?job_id=363761394&repo=autoland&lineNumber=5177

Failure line(s): PROCESS-CRASH | devtools/client/performance-new/test/browser/browser_devtools-interrupted.js | application crashed [@ audioipc2::ipccore::EventLoopHandle::add_connection]

Flags: needinfo?(kinetik)
Attached file GitHub Pull Request (deleted) —
Flags: needinfo?(kinetik)
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87c9ad37b4f7 Enable AudioIPC rework for Windows and Linux by default. r=cubeb-reviewers,padenot
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: Future → 98 Branch
Regressions: 1750345
Regressions: 1750444
Regressions: 1750477
Depends on: 1750810

Bug 1750810 will revert this change for Linux in Nightly 98 until the existing issues are resolved. Windows will remain enabled as we've had no reports of issues and there are zero Windows crashes showing up on crash-stats.

Regressions: 1750708
Regressions: 1751318
Regressions: 1754623
Regressions: 1754877
Depends on: 1757473
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: