Closed
Bug 1726598
Opened 3 years ago
Closed 3 years ago
sFactoryShutdown is never set to true and might be obsolete as well as sMutex
Categories
(Core :: Storage: Cache API, task, P3)
Core
Storage: Cache API
Tracking
()
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: jstutte, Assigned: hxu)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
Looking at searchfox it seems, we do never set sFactoryShutdown to true but we check it even guarded by a mutex.
This sMutex seems obsolete, too.
|
Reporter | |
Updated•3 years ago
|
Keywords: good-first-bug
|
|
Reporter | |
Updated•3 years ago
|
Severity: -- → S4
Priority: -- → P3
|
|
Reporter | |
Comment 1•3 years ago
|
||
The original intent is now implemented here.
|
||
Comment 2•3 years ago
|
||
We were setting sFactoryShutdown to true in the original patch, so we should first find out why it was changed/removed. I guess the async quota client shutdown may have something to do with that.
|
|
Reporter | |
Comment 3•3 years ago
|
||
It happened in bug 961049 with Part 6: Quota Manager on PBackground cache changes. Not sure if this tells us "why" though - I read in the review comments:
> Do we still need sMutex? It seems everything is running on a single thread
> now.
We actually don't need sBackgroundThread anymore, so I removed it.
but sMutex did actually not go away. It looks like if this is an unwanted remainder of that patch already.
|
|
||
Comment 4•3 years ago
|
||
Ok, it seems I will have to refresh my memory :)
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → hxu
|
|
Assignee | |
Comment 5•3 years ago
|
||
Pushed by jstutte@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98b67986e12d
Remove sFactoryShutdown and sMutex from dom::cache::Manager since they are obselete. r=dom-storage-reviewers,jstutte
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•