Closed Bug 1726944 Opened 3 years ago Closed 3 years ago

Update SeaMonkey website for 2.53.9 final release

Categories

(SeaMonkey :: Website, task)

Product:
SeaMonkey
Component:
Website
Version:
Production
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: frg, Assigned: iannbugzilla)

References

Details

(Whiteboard: SM2.53.9)

Attachments

(3 files, 1 obsolete file)

1726944-website-2539.patch
(deleted), patch
frg
: review+
ewong
: feedback+
iannbugzilla
: feedback?
rsx11m.pub
njsg
: feedback+
Details | Diff | Splinter Review
1726944-website-addendum-v2-2539.patch
(deleted), patch
frg
: review+
njsg
: feedback+
Details | Diff | Splinter Review
1726944-3-website-addendum-updates-2539.patch
(deleted), patch
iannbugzilla
: review+
njsg
: feedback+
Details | Diff | Splinter Review

+++ This bug was initially created as a clone of Bug #1720687 +++

The usual. Add news download section and release notes.

Assignee: nobody → iann_bugzilla
Status: NEW → ASSIGNED
Attached patch 1726944-website-2539.patch (deleted) — — Splinter Review

Do any of the backports need to be mentioned in the release notes / news? If so which ones?

Attachment #9237380 - Flags: review?(frgrahl)
Attachment #9237380 - Flags: feedback?(rsx11m.pub)
Attachment #9237380 - Flags: feedback?(nunojsg)
Attachment #9237380 - Flags: feedback?(ewong)

Comment on attachment 9237380 [details] [diff] [review]
1726944-website-2539.patch

The "what's new [...]" link href is missing the end quote; other than that looks good to me.

Attachment #9237380 - Flags: feedback?(nunojsg) → feedback+
Attached patch 1726944-website-addendum-2539.patch (obsolete) (deleted) — — Splinter Review

Fixed the link and did some changes. Please check. Happy to be merged with the main patch

Attachment #9237818 - Flags: review?(iann_bugzilla)
Attachment #9237818 - Flags: feedback?(nunojsg)

Comment on attachment 9237380 [details] [diff] [review]
1726944-website-2539.patch

Mostly good but see my suggestions/corrections in separate patch.

Attachment #9237380 - Flags: review?(frgrahl) → review+
Comment on attachment 9237818 [details] [diff] [review] 1726944-website-addendum-2539.patch >+++ b/src/news.en.xml >-platform code. <font color="#ff0000"><strong>Before installing it make a full >-backup of your profile and thoroughly read and follow the <a >-href="releases/seamonkey2.53.9/">Release Notes</a></strong></font>. >-</p> >+platform code. Read the full <a href="releases/seamonkey2.53.9/">Release Notes< >+/a> for further information. Nit: split between Release and Notes not within the tag </a> >+++ b/src/releases/2.53.9.en.html >+ distributions only. >+ <br>The Windows versions is supported on Windows 7 and higher only. It will Nit: "are" rather than "is" >+ not install on an unsupported version. The x64 version will only run on a x64 >+ Windows version. Running the unzipped package on an unsupported version might >+ result in an error displayed or in erratic program behaviour.<br> If you use Nit: start the <br> on a new line and no space between <br> and If. >+ a previous SeaMonkey x86 Windows version please uninstall it before >+ installing the x64 version. Your profile data will be preserved doing this. >+++ b/src/releases/seamonkey2.53.9/index.en.html >+ <a href="https://gitlab.com/seamonkey-project">gitlab</a>. For accessing >+ the site you currently need to use the >+ <a href="https://github.com/JustOff/github-wc-polyfill/accessible"> web Nit: no space between > and web >+ components polyfill add-on</a>. r=me with those items fixed.
Attachment #9237818 - Flags: review?(iann_bugzilla) → review+
Comment on attachment 9237380 [details] [diff] [review] 1726944-website-2539.patch Review of attachment 9237380 [details] [diff] [review]: ----------------------------------------------------------------- Aside for the note, things look good. Will most likely push this soon. ::: src/releases/seamonkey2.53.9/index.en.html @@ +27,5 @@ > </p> > > <p> > +<font color="#ff0000"><b>Automatic upgrades from previous 2.53.x versions are > +enabled for this release.</b></font> Just realized that 2.53.4 won't be able to update to 2.53.9 since it looks at aus2-community.mozilla.org. Pinged IanN on this on irc.. wondering if we should also move aus2-community to use the latest backend.
Attachment #9237380 - Flags: feedback?(ewong) → feedback+

nits fixed carrying forward r+

Attachment #9237818 - Attachment is obsolete: true
Attachment #9237818 - Flags: feedback?(nunojsg)
Attachment #9237938 - Flags: review+
Attachment #9237938 - Flags: feedback?(nunojsg)

njsg found a few incorrect no update statements in the release notes.

I left them in 2.53.5 and 2.53.7 because these release will not update. 2.53.7 only en-US and zh-TW but before we add a lenghty explanation ... :)

Attachment #9237941 - Flags: review?(iann_bugzilla)
Attachment #9237941 - Flags: feedback?(nunojsg)

Comment on attachment 9237941 [details] [diff] [review]
1726944-3-website-addendum-updates-2539.patch

LGTM r=me

Attachment #9237941 - Flags: review?(iann_bugzilla) → review+
Attachment #9237938 - Flags: feedback?(nunojsg) → feedback+
Attachment #9237941 - Flags: feedback?(nunojsg) → feedback+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Blocks: 1731508
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: