Closed Bug 1727146 Opened 3 years ago Closed 3 years ago

ClearDataService - Only clear the preflight cache on user request.

Categories

(Core :: Privacy: Anti-Tracking, enhancement)

Product:
Core
Component:
Privacy: Anti-Tracking
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
93 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 92+ fixed
firefox91 --- wontfix
firefox92 + fixed
firefox93 + fixed

People

(Reporter: pbz, Assigned: pbz)

References

Details

Attachments

(1 file)

Bug 1727146 - Only clear the preflight cache on user request. r=johannh!
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-beta+
RyanVM
: approval-mozilla-esr91+
Details

Bug 1704110 added the PreflightCacheCleaner. Currently the entire cache is cleared, even if deleteByBaseDomain or deleteByPrincipal is called. This can lead to bugs like Bug 1721084.
We should only clear the entire preflight cache if the request to clear data came from the user.

Marking this as a sec bug, because Bug 1704110 is not yet public.

Assignee: nobody → pbz
Status: NEW → ASSIGNED
Attachment #9237525 - Attachment description: Bug 1704110 - Only clear the preflight cache on user request. r=johannh! → Bug 1727146 - Only clear the preflight cache on user request. r=johannh!
Group: core-security → dom-core-security

https://hg.mozilla.org/mozilla-central/rev/1d4ddeeef588

Group: dom-core-security → core-security-release
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox91: --- → wontfix
status-firefox92: --- → affected
status-firefox93: --- → fixed
status-firefox-esr78: --- → unaffected
status-firefox-esr91: --- → affected
tracking-firefox92: --- → +
tracking-firefox93: --- → +
tracking-firefox-esr91: --- → 92+
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(pbz)

Comment on attachment 9237525 [details]
Bug 1727146 - Only clear the preflight cache on user request. r=johannh!

Beta/Release Uplift Approval Request

  • User impact if declined: The preflight cache cleaner introduced in Bug 1704110 also runs when we purge trackers at a set interval. Since the preftlight cache cleaner does not (yet) have the capability to clear data for the specific origin the PurgeTrackerService passes, it will clear the entire cache whenever the PurgeTrackerService runs.
    This means the preflight cache sometimes won't work expected and additional preflight requests will be sent, potentially degrading performance for some websites whenever the PurgeTrackerService runs.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The (non-test) code change is very small. Callers of the PreflightCacheCleaner are well known.
  • String changes made/needed:
Flags: needinfo?(pbz)
Attachment #9237525 - Flags: approval-mozilla-beta?

Comment on attachment 9237525 [details]
Bug 1727146 - Only clear the preflight cache on user request. r=johannh!

Approved for 92.0b8 and 91.1esr.

Attachment #9237525 - Flags: approval-mozilla-esr91+
Attachment #9237525 - Flags: approval-mozilla-beta?
Attachment #9237525 - Flags: approval-mozilla-beta+
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: