Closed Bug 1727497 Opened 3 years ago Closed 3 years ago

Add MOZ_ALWAYS_SUCCEEDS to all message dispatches that unblock shutdown

Categories

(Core :: Storage: Cache API, task)

Product:
Core
Component:
Storage: Cache API
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox94 --- fixed

People

(Reporter: jstutte, Assigned: hxu)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Bug 1727497 - Add MOZ_DIAGNOSTIC_ASSERT in CacheStreamControlParent::CloseAll(); r=#dom-storage
(deleted), text/x-phabricator-request
Details
Bug 1727497 - Return Dispatch result from NS_ProxyRelease; r=#dom-storage-reviewers,#xpcom-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1727497 - Add MOZ_ALWAYS_SUCCEEDS when calling dispatch functions during dom/cache shutdown; r=#dom-storage-reviewers
(deleted), text/x-phabricator-request
Details
Bug 1727497 - Revert the usage of MOZ_DIAGNOSTIC_ASSERT in CacheStreamControlParent::CloseAll(); r=#dom-storage-reviewers
(deleted), text/x-phabricator-request
Details

Investigation started at bug 1588498 comment 19.

Starting from CacheQuotaClient::InitiateShutdown() we need to identify all potential message dispatches during shutdown which are needed to unblock but that might silently fail.

Examples of unsafe dispatches:

Examples of safeguarded dispatches:

Summary: Add MOZ_ALWAYS_SUCCESS/MOZ_DIAGNOSTIC_ASSERT to all message dispatches that unblock shutdown → Add MOZ_ALWAYS_SUCCEEDS/MOZ_DIAGNOSTIC_ASSERT to all message dispatches that unblock shutdown
Assignee: nobody → hxu
Keywords: leave-open
Attachment #9239352 - Attachment description: Bug 1727497 - Add MOZ_ALWAYS_SUCCEEDS in ReadStream::Inner::CloseStream() when calling Close(); r=#dom-storage → Bug 1727497 - Add MOZ_ALWAYS_SUCCEEDS in ReadStream::Inner::CloseStream() and Context::ThreadsafeHandle::~ThreadsafeHandle(); r=#dom-storage,#xpcom-reviewers
Attachment #9239352 - Attachment description: Bug 1727497 - Add MOZ_ALWAYS_SUCCEEDS in ReadStream::Inner::CloseStream() and Context::ThreadsafeHandle::~ThreadsafeHandle(); r=#dom-storage,#xpcom-reviewers → Bug 1727497 - Returning dispatch result from NS_ProxyRelease; r=#dom-storage,#xpcom-reviewers!
Attachment #9239351 - Attachment description: Bug 1727497 - Add MOZ_DIAGNOSTIC_ASSERT in CacheStreamControlParent::CloseAll() and Context::ThreadsafeHandle::~ThreadsafeHandle(); r=#dom-storage → Bug 1727497 - Add MOZ_DIAGNOSTIC_ASSERT in CacheStreamControlParent::CloseAll(); r=#dom-storage
Pushed by jstutte@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dcea64592be7 Add MOZ_DIAGNOSTIC_ASSERT in CacheStreamControlParent::CloseAll(); r=dom-storage-reviewers,jstutte
Attachment #9239352 - Attachment description: Bug 1727497 - Returning dispatch result from NS_ProxyRelease; r=#dom-storage,#xpcom-reviewers! → Bug 1727497 - Return Dispatch result from NS_ProxyRelease; r=#dom-storage-reviewers,#xpcom-reviewers
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2fca70f014e0 Return Dispatch result from NS_ProxyRelease; r=dom-storage-reviewers,xpcom-reviewers,nika,janv
Summary: Add MOZ_ALWAYS_SUCCEEDS/MOZ_DIAGNOSTIC_ASSERT to all message dispatches that unblock shutdown → Add MOZ_ALWAYS_SUCCEEDS to all message dispatches that unblock shutdown
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c30f7d0aa9b Add MOZ_ALWAYS_SUCCEEDS when calling dispatch functions during dom/cache shutdown; r=dom-storage-reviewers,janv
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b93ff7be64e7 Revert the usage of MOZ_DIAGNOSTIC_ASSERT in CacheStreamControlParent::CloseAll(); r=dom-storage-reviewers,janv
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
status-firefox94: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: