Some items are not sentence case in overflow menu's panel
Categories
(Firefox :: Menus, defect, P1)
Tracking
()
People
(Reporter: cgeorgiu, Assigned: mhowell)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
Affected versions
- latest Nightly 93.0a1
- Beta 92.0b9
- Release 91.0.2
Affected platforms
- Windows 10 x64
- macOS 11
- Ubuntu 18.04 x64
Steps to reproduce
- Launch Firefox.
- Go to the Customize page.
- Drag & drop all the items to the overflow menu.
- Close the Customize page.
- Observe the elements from the panel and sub panels.
Expected result
- All items are written in sentence case.
Actual result
- Some items are not sentence cased in the panel and sub panel.
Suggested Severity
- S4, since this won't affect affect the Firefox functionality or the end users.
Regression range
- This is not a regression.
Additional notes
- Please see the attached screenshots.
Reporter | ||
Comment 1•3 years ago
|
||
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 3•3 years ago
|
||
This required migrating several strings to Fluent, and the bulk of this patch
is those migrations. The rest of the items matched up with an entry in the app
menu, so those items were switched over to use the app menu strings.
Updated•3 years ago
|
Comment 6•3 years ago
|
||
Backed out for causing mochitest failures in en-US/appmenuitem-new-private-window2
Backout link https://hg.mozilla.org/integration/autoland/rev/14616096bc40dbbfe41f7dd366d167e6711e9c88
Assignee | ||
Comment 7•3 years ago
|
||
The error in the logs is that a Fluent variable didn't resolve, but that's not the real problem; the real problem is that I accidentally added a tooltip to an app menu item, which aren't supposed to have any. The fix then will be to stop that from happening.
Assignee | ||
Comment 8•3 years ago
|
||
I've submitted a patch that seems to fix these failures, but the change is significant enough that I've re-requested review for it.
Comment 10•3 years ago
|
||
bugherder |
Comment 11•3 years ago
|
||
The patch landed in nightly and beta is affected.
:mhowell, is this bug important enough to require an uplift?
If not please set status_beta
to wontfix
.
For more information, please visit auto_nag documentation.
Comment 12•3 years ago
|
||
I can confirm the items inside the overflow menu are in sentence case across platforms ( Windows 10, Ubuntu 18.04, macOS 12.0 - 21A5506j version) with the latest Nightly build. But the Manage account inside the Synced Tabs subpanel is no longer left aligned. Is this intentional? Or should I fill a separate bug for it?
Assignee | ||
Comment 13•3 years ago
|
||
(In reply to Release mgmt bot [:sylvestre / :calixte / :marco for bugbug] from comment #11)
The patch landed in nightly and beta is affected.
:mhowell, is this bug important enough to require an uplift?
If not please setstatus_beta
towontfix
.
It is not important enough, no.
(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #12)
Created attachment 9240894 [details]
screenshot alignment.pngI can confirm the items inside the overflow menu are in sentence case across platforms ( Windows 10, Ubuntu 18.04, macOS 12.0 - 21A5506j version) with the latest Nightly build. But the Manage account inside the Synced Tabs subpanel is no longer left aligned. Is this intentional? Or should I fill a separate bug for it?
That is not intentional, no, and I have no idea how it happened; please file that and CC me, thanks.
Comment 14•3 years ago
|
||
Based on comment 12 I will mark this issue as verified fixed. For the additional encountered issue I've filled bug 1730835.
Description
•