Closed Bug 1728063 Opened 3 years ago Closed 3 years ago

[win7] Zoom percentage is blurred inside customize mode with High Contrast active

Categories

(Firefox :: Toolbars and Customization, defect)

Product:
Firefox
Component:
Toolbars and Customization
Platform:
Desktop
Windows 7
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Milestone:
93 Branch
Project Flags:
Accessibility Severity s4
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- verified
firefox91 --- wontfix
firefox92 --- wontfix
firefox93 --- verified

People

(Reporter: atrif, Assigned: bigiri)

References

(Regression)

Details

(Keywords: access, regression)

Attachments

(2 files)

win7_contrast.png
(deleted), image/png
Details
Bug 1728063 - Remove blur from Zoom percentage in customize mode r=Jaws
(deleted), text/x-phabricator-request
RyanVM
: approval-mozilla-esr91+
Details
Attached image win7_contrast.png (deleted) —

Affected versions

  • 92.0b9 (20210826192006)
  • 93.0a1 (20210829215733)
  • 91.0.2 (20210823123856)
  • 91.0.1esr (20210816144842)

Affected platforms

  • Windows 7x64

Steps to reproduce

  1. Enable High contrast and open Firefox.
  2. Enter customize mode and add zoom controls on toolbar.

Expected result

  • Zoom controls are displayed as expected.

Actual result

  • Zoom percentage is blurred inside customize mode.

Regression range

Notes

  • Attached a screenshot.
Has Regression Range: --- → yes
Has STR: --- → yes

This is caused by https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/toolkit/themes/windows/global/toolbarbutton.css#42.

We shouldn't apply this rule if @media (prefers-contrast) applies. Bernard, can you take this?

Flags: needinfo?(bigiri)
Keywords: access
Assignee: nobody → bigiri
Flags: needinfo?(bigiri)
Whiteboard: [access-s4]
Points: --- → 1

Removed text-shadow from toolbarbuttons when in high contrast mode in Windows Classic themes to prevent blurry appearance of zoom percentage number.

Pushed by bigiri@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adb32230803a
Remove blur from Zoom percentage in customize mode r=jaws

https://hg.mozilla.org/mozilla-central/rev/adb32230803a

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox93: fix-optional → fixed
Resolution: --- → FIXED
Target Milestone: --- → 93 Branch
Flags: qe-verify+

Please nominate this for ESR91 approval when you get a chance.

Flags: needinfo?(bigiri)

Comment on attachment 9238784 [details]
Bug 1728063 - Remove blur from Zoom percentage in customize mode r=Jaws

ESR Uplift Approval Request

  • If this is not a sec:{high,crit} bug, please state case for ESR consideration: Impacts the appearance of Firefox on Windows 7.
  • User impact if declined: The appearance of the toolbar customize mode will display poorly. The appearance of the Zoom control zoom percentage will appear blurry in Windows 7.
  • Fix Landed on Version: 93
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): CSS only changes.
  • String or UUID changes made by this patch:
Flags: needinfo?(bigiri)
Attachment #9238784 - Flags: approval-mozilla-esr91?
QA Whiteboard: [qa-triaged]

Comment on attachment 9238784 [details]
Bug 1728063 - Remove blur from Zoom percentage in customize mode r=Jaws

Approved for 91.2esr.

Attachment #9238784 - Flags: approval-mozilla-esr91? → approval-mozilla-esr91+

Verified fixed with Firefox 93.0b6 and 91.2.0esr (20210916164457) on Windows 7x64. The zoom percentage is correctly displayed inside customize menu while having High Contrast active.

Status: RESOLVED → VERIFIED
status-firefox93: fixed → verified
status-firefox-esr91: fixed → verified
Flags: qe-verify+
Accessibility Severity: --- → s4
Whiteboard: [access-s4]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: