Closed
Bug 1728070
Opened 3 years ago
Closed 3 years ago
MarkupView is leaked from a dangling mousemove event listener
Categories
(DevTools :: Inspector, defect)
DevTools
Inspector
Tracking
(firefox94 fixed)
RESOLVED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-perf-stability-triage )
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The following code:
https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/devtools/client/inspector/markup/markup.js#342-348
this._elt.addEventListener(
"mousemove",
() => {
this._initTooltips();
},
{ once: true }
);
registers a mousemove listener whick leaks the MarkupView instance if no mousemove happens on this._elt. As we never try to unregister the listener on MarkupView's destroy.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9238461 -
Attachment description: Bug 1728070 - [devtools] Avoid leaking the MarkupView via a DOM event listener → Bug 1728070 - [devtools] Avoid leaking the MarkupView via a DOM event listener.
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/881bdd5dcf52
[devtools] Avoid leaking the MarkupView via a DOM event listener. r=nchevobbe
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•