Closed
Bug 1728102
Opened 3 years ago
Closed 3 years ago
Interactions.jsm throws on removing a non-existing idle observer
Categories
(Toolkit :: Places, defect, P2)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
94 Branch
Tracking | Status | |
---|---|---|
firefox94 | --- | fixed |
People
(Reporter: mak, Assigned: mak)
References
Details
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
Interactions.jsm adds an idle observer only if the pref is set, but unit() tried to remove it regardless. removeIdleObserver unfortunately throws in that case, and thus interrupts browserglue uninit process
https://searchfox.org/mozilla-central/rev/5a362eb7d054740dc9d7c82c79a2efbc5f3e4776/browser/components/BrowserGlue.jsm#1967-1974
Assignee | ||
Updated•3 years ago
|
Severity: -- → S3
Priority: -- → P2
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
Trying to make _onQuitApplicationGranted more robust, copying the method used for idle tasks.
If successful, we could re-apply the same method to other parts of browserglue doing init/uninit.
To fail tests, this is crashing fatally, it would be nice if we could fail single tests, but
quit-application-granted is too late for test harness failure detection.
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/67b3dda3d4a7
Interactions.jsm uninit is throwing on removing a non-existing idle observer. r=Standard8
Comment 3•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox94:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•