Closed Bug 1728688 Opened 3 years ago Closed 3 years ago

only call NotifyContentfulPaintForRootContentDocument for root content documents

Categories

(Core :: Performance, defect)

defect

Tracking

()

RESOLVED INVALID

People

(Reporter: tnikkel, Unassigned)

Details

Attachments

(1 obsolete file)

https://hg.mozilla.org/integration/autoland/rev/47629f89cb6a

changed it so that mFirstContentfulPaintTransactionId was set to something for non-root content documents. In nsPresContext::NotifyDidPaintForSubtree we use the existence of mFirstContentfulPaintTransactionId to determine to call NotifyContentfulPaintForRootContentDocument.

If the intent is to call NotifyContentfulPaintForRootContentDocument for all documents we should change the name, but as it is there are a couple other similarly named functions that do only get called for root content documents so bringing these all to be the same would be good.

Blocks: 1728690
Assignee: nobody → tnikkel
Status: NEW → ASSIGNED
Attachment #9239059 - Attachment is obsolete: true

Based on the comments in https://phabricator.services.mozilla.com/D124273 I may have mis-understood the problem here. Un-assigning.

Assignee: tnikkel → nobody
Status: ASSIGNED → NEW
No longer blocks: 1728690

Set release status flags based on info from the regressing bug 1518999

Should we close this bug as invalid? thanks

Flags: needinfo?(sefeng)

Yeah, I think that's what we'd like to do.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(sefeng)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: