Closed Bug 1728911 Opened 3 years ago Closed 3 years ago

Update help for clear private data preferences and dialog

Categories

(SeaMonkey :: Help Documentation, defect, P1)

Product:
SeaMonkey
Component:
Help Documentation
Type:
defect

Tracking

(seamonkey2.53+ fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.91
Tracking Flags:
Tracking Status
seamonkey2.53 + fixed

People

(Reporter: frg, Assigned: frg)

References

Details

(Whiteboard: SM2.53.10)

Attachments

(1 file, 1 obsolete file)

1728911-clearprivatedatahelp-v1_1-25310.patch
(deleted), patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

+++ This bug was initially created as a clone of Bug #1621445 +++

Help needs to be adapted for the changed preferences and clean private data dialog.

tracking-firefox92: ? → ---
tracking-firefox93: ? → ---
Attached patch 1728911-clearprivatedatahelp-25310.patch (obsolete) (deleted) — — Splinter Review

I left nc:link="using_priv_help.xhtml#clear_private_data_now" alone and didn't rename it becuase of localized help files which are infrequently updated.

[Approval Request Comment]
Regression caused by (bug #): Bug 1621445
User impact if declined: wrong help
Testing completed (on m-c, etc.): 2.53.10
Risk to taking this patch (and alternatives if risky): trivial
String changes made by this patch: help changes

Attachment #9239287 - Flags: review?(iann_bugzilla)
Attachment #9239287 - Flags: approval-comm-release?
Attachment #9239287 - Flags: approval-comm-esr60?
Comment on attachment 9239287 [details] [diff] [review] 1728911-clearprivatedatahelp-25310.patch >+++ b/suite/locales/en-US/chrome/common/help/using_priv_help.xhtml >+ <li><strong>Clear these private data items</strong>: For each >+ <a href="#types_of_private_data">type of private data</a>, a separate >+ option is provided whether or not to clear any stored items of this >+ specific type. Check the respective box for each item to be deleted by >+ default when clearing is requested by you. The choices are split beween Nit: between r/a=me with that fixed
Attachment #9239287 - Flags: review?(iann_bugzilla)
Attachment #9239287 - Flags: review+
Attachment #9239287 - Flags: approval-comm-release?
Attachment #9239287 - Flags: approval-comm-release+
Attachment #9239287 - Flags: approval-comm-esr60?
Attachment #9239287 - Flags: approval-comm-esr60+

NIT fixed and a paragraph changed after feedback from njsg.

Check the respective box for each item to be deleted. The choices are split between manually clearing via dialog and automatically initiated when closing &brandShortName;

r/a+ retained. Will checkin if I no objections today.

Attachment #9239287 - Attachment is obsolete: true
Attachment #9240038 - Flags: review+
Attachment #9240038 - Flags: approval-comm-release+
Attachment #9240038 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/e01415f81aa4
Bring clear private data section in help up to spec. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey 2.91
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: