Closed Bug 1729061 Opened 3 years ago Closed 3 years ago

Log accessible cache discrepancies

Categories

(Core :: Disability Access APIs, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox94 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

For manual testing purposes, we should have the ability to log instances when the value the AT receives from the cache differs from the computed value in content. We can't use sync calls because that isn't allowed on Windows, so the actual comparison happens in the content process using an async call from parent with the cache payload.

This is a very crude cache review method, and there will be plenty of false positives since the state of content/parent is not guaranteed to be synced.

For example, if run with a browser e10s name test, it will flag a lot mismatches because the content is always one state ahead of parent. Nonetheless, this already helped me find a bug where we were inadvertently storing DeleteEntry values.

Type: defect → enhancement
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a6d7f0da2513 Introduce cache verification logging. r=Jamie

Backed out changeset a6d7f0da2513 (Bug 1729061) for causing bustages on DocAccessibleChildBase.cpp.
Backout link
Push with failures H
Failure Log

Flags: needinfo?(eitan)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:eeejay, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(jteh)
Flags: needinfo?(eitan)
Flags: needinfo?(jteh)
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4d44c5b706db Introduce cache verification logging. r=Jamie
Pushed by eisaacson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/976f1b8e7f85 Introduce cache verification logging. r=Jamie
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
Flags: needinfo?(eitan)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: