Closed Bug 1729110 Opened 3 years ago Closed 3 years ago

getSynchronizationSources() intermittently drops SSRC for video

Categories

(Core :: WebRTC: Networking, defect, P2)

Product:
Core
Component:
WebRTC: Networking
Version:
78 Branch
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1654112

People

(Reporter: jib, Unassigned)

References

Details

+++ This bug was initially created as a clone of Bug #1727800 +++

STR:

  1. Open https://jsfiddle.net/jib1/tj0x3sv1, allow cam + mic, and wait

Expected result:

audio: 0 CSRCs, 0 SSRCs. video: 0 CSRCs, 0 SSRCs.
checking
connected
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
(repeats forever)

Actual result:

audio: 0 CSRCs, 0 SSRCs. video: 0 CSRCs, 0 SSRCs.
checking
connected
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 0 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 0 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 1 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 0 SSRCs.
audio: 0 CSRCs, 1 SSRCs. video: 0 CSRCs, 0 SSRCs.

Note the intermittent 0 SSRCs for video only.

Regression range

23:09.52 INFO: Last good revision: a77ca5bd6b7c49099c672e103771ca2bf077cc40 (2020-05-14)
23:09.52 INFO: First bad revision: f340bbb582d16c083344b1370bd4e4d4caf5fb17 (2020-05-15)
23:09.52 INFO: Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a77ca5bd6b7c49099c672e103771ca2bf077cc40&tochange=f340bbb582d16c083344b1370bd4e4d4caf5fb17
:
:
23:16.71 INFO: There are no build artifacts for these changesets (they are probably too old).

Unfortunately, mozregression was not conclusive.

Oddly, this almost goes back to the introduction of SSRC for video, but not quite. The 2020-05-14 version had video working reliably, as far as I could tell. It's possible this was a fluke, though a tested it for a good minute.

Version: Firefox 91 → 78 Branch

Jan-Ivar, could you give it a shot with our latest libwebrtc merge build?
https://treeherder.mozilla.org/jobs?repo=try&revision=17012af0de0bd9b4b38d4735c183a537cd1fdce8

Flags: needinfo?(jib)

I'm not able to reproduce with the build in comment 1. 👍

Severity: -- → S3
Depends on: 1654112
Flags: needinfo?(jib)
Priority: -- → P2

Might want to look again later, I have made changes that are not in that build to the threading model (refactored how ssrcs are set), ssrc switching and GetRtpSources (used internally for getSynchronizationSources), all on the conduits.

jib, can you verify again now that bug 1654112 has landed?

Flags: needinfo?(jib)

Confirmed fixed.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(jib)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.