Misspelled word not marked as such
Categories
(Core :: Spelling checker, defect, P3)
Tracking
()
People
(Reporter: mbrodesser-Igalia, Assigned: masayuki)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
STR:
- Open
data:text/html,<textarea rows=20 cols=50>That undfgdfg seems OK.</textarea>
- Click immediately after "undfgdfg".
- Add a space.
- Remove the space.
- Press the "End" key.
- Add a space and write something.
Expected:
"undfgdfg" would be marked as misspelled after step 5.
Actual:
it isn't.
Clicking outside the textarea fixes this, presumably because it scheduled a full spellchecking. Happened on Ubuntu 20.04.
Comment 1•3 years ago
|
||
I can reproduce this in Nightly94.0a1 Windows10.
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d10dc4dc4162b15320bf468adaf5cf0859666c23&tochange=2ab582bacc98fecfc3cc52b3f275a23ff40a683f
Comment 2•3 years ago
|
||
I confirmed that Setting dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content
to false
fixed this issue.
Assignee | ||
Comment 3•3 years ago
|
||
It means that spellchecker has a keypress
event listener in the default group.
Reporter | ||
Updated•3 years ago
|
Assignee | ||
Comment 4•3 years ago
|
||
Changing severity to S3 because of not serious, but maybe annoying bug.
Assignee | ||
Comment 5•3 years ago
|
||
Currently, mozInlineSpellChecker
handles events in the default group. This
means that the listener may not run if web app stops the propagation. For
keeping the event listener order as far as possible, this patch changes to
listen to the event at capturing phase in the system group (editor handles
the events at bubbling phase in the system group).
Additionally, it listens to keypress
events for handling caret/selection
changes. However, they should be handled at keydown
because those keys
are not printable. Therefore, this patch changes to listen to keydown
events, but this could change the race between running the scheduled spellcheck
and following keypress
event which is dispatched only for chrome code and
C++ event listeners. However, this may not change it actually because the
race is changed only when the following keypress
event delays too much.
https://searchfox.org/mozilla-central/rev/2eebd6e256fa0355e08421265e57ee1307836d92/extensions/spellcheck/src/mozInlineSpellChecker.cpp#503-504
Comment 7•3 years ago
|
||
bugherder |
Updated•3 years ago
|
Description
•