Closed Bug 1729653 Opened 3 years ago Closed 3 years ago

Misspelled word not marked as such

Categories

(Core :: Spelling checker, defect, P3)

Desktop
All
defect

Tracking

()

RESOLVED FIXED
94 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox-esr91 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- fixed

People

(Reporter: mbrodesser-Igalia, Assigned: masayuki)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

STR:

  1. Open data:text/html,<textarea rows=20 cols=50>That undfgdfg seems OK.</textarea>
  2. Click immediately after "undfgdfg".
  3. Add a space.
  4. Remove the space.
  5. Press the "End" key.
  6. Add a space and write something.

Expected:
"undfgdfg" would be marked as misspelled after step 5.

Actual:
it isn't.

Clicking outside the textarea fixes this, presumably because it scheduled a full spellchecking. Happened on Ubuntu 20.04.

Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: regression
OS: Unspecified → All
Regressed by: 1440189
Hardware: Unspecified → Desktop

I confirmed that Setting dom.keyboardevent.keypress.dispatch_non_printable_keys_only_system_group_in_content to false fixed this issue.

It means that spellchecker has a keypress event listener in the default group.

Changing severity to S3 because of not serious, but maybe annoying bug.

Assignee: nobody → masayuki
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P3
No longer blocks: 1633695

Currently, mozInlineSpellChecker handles events in the default group. This
means that the listener may not run if web app stops the propagation. For
keeping the event listener order as far as possible, this patch changes to
listen to the event at capturing phase in the system group (editor handles
the events at bubbling phase in the system group).

Additionally, it listens to keypress events for handling caret/selection
changes. However, they should be handled at keydown because those keys
are not printable. Therefore, this patch changes to listen to keydown
events, but this could change the race between running the scheduled spellcheck
and following keypress event which is dispatched only for chrome code and
C++ event listeners. However, this may not change it actually because the
race is changed only when the following keypress event delays too much.
https://searchfox.org/mozilla-central/rev/2eebd6e256fa0355e08421265e57ee1307836d92/extensions/spellcheck/src/mozInlineSpellChecker.cpp#503-504

Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/ca8fcd42078a Make `mozInlineSpellChecker` handle events in the system group at capturing phase r=m_kato
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: