[vaapi] Anti-harassment course video gets corrupted - vaExportSurfaceHandle() failure
Categories
(Core :: Audio/Video: Playback, defect, P5)
Tracking
()
People
(Reporter: emilio, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
text/plain
|
Details |
Profile with screenshots here: https://share.firefox.dev/3tt78bA
Crash report is bp-b73764dd-fd33-41e4-8e74-1c63c0210909, though I'm not sure where the drawWindow call comes from.
I've confirmed that media.ffmpeg.vaapi.enabled=false
fixes it, but I'm not sure what the next steps are since I suspect I can't give you access to the page... Would some logs be useful? When the video pauses the following is in the devtools console:
Object { error: "mediasource", event: "MEDIA_ERR_DECODE (NS_ERROR_OUT_OF_MEMORY (0x8007000e) - mozilla::MediaResult mozilla::FFmpegVideoDecoder<58>::CreateImageVAAPI(int64_t, int64_t, int64_t, MediaDataDecoder::DecodedData &): Unable to get frame by vaExportSurfaceHandle())", type: "error" }
Comment 1•3 years ago
|
||
Yes, the log of MOZ_LOG="Dmabuf:5, PlatformDecoderModule:5" will help here.
Updated•3 years ago
|
Reporter | ||
Comment 2•3 years ago
|
||
Comment 3•3 years ago
|
||
Have you tried to set a bookmark or opened another widget while the video was playing?
Reporter | ||
Comment 4•3 years ago
|
||
Nope
Reporter | ||
Comment 5•3 years ago
|
||
But perhaps the newtab screenshots code was running or something.
Comment 6•3 years ago
|
||
Yes, you're running out of free vaapi dmabuf surfaces. We should handle that situation by caching frames and free vaapi dmabuf surfaces early.
Triaging -- p5 as Media don't currently handle vaapi in house. Please set severity as you see fit.
Actually, let me set that to appease some more triage tooling. S3 since we can pref this off. I could see this being S2 also, if folks feel strongly.
Updated•3 years ago
|
Comment 9•3 years ago
|
||
Emilio, do you still see that? Looks like DMABUFSurfaceImage::GetAsSourceSurface() is called to create a shapshot of the video. I guess something is playing video on background while a video thumbnail is displayed or so. Do you have any reproducer?
I think we should fallback to SW decode or stop HW decode when we're running out of free HW surfaces (we know how free HW surfaces is available). Especially h264 may be affected by this one.
Comment 10•3 years ago
|
||
Would be great to see platform decode log of this case, please run with MOZ_LOG="Dmabuf:5, PlatformDecoderModule:5" and attach the log here.
Thanks.
Reporter | ||
Comment 11•3 years ago
|
||
I managed to log in back into that course and videos play fine now, so let's call this fixed. If I see it again I'll re-file. Thanks!
Description
•