Closed Bug 1729918 Opened 3 years ago Closed 3 years ago

Learn what percentage of OOM crashes happened during the inactive state

Categories

(Firefox :: Tabbed Browser, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
95 Branch
Tracking Status
firefox95 --- fixed

People

(Reporter: toshi, Assigned: toshi)

References

Details

Attachments

(3 files, 1 obsolete file)

Currently we don't monitor memory while the user is inactive not to consume CPU power too much. Depending on the percentage of OOM crashes during the inactive state, however, we may consider to continue monitoring memory regardless of the user's active/inactive state. This task is to introduce and analyze crash annotation.

Attached file data-review-request-bug-1729918 (obsolete) (deleted) —
Attachment #9240863 - Flags: data-review?(chutten)

Comment on attachment 9240863 [details]
data-review-request-bug-1729918

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Toshihito Kikuchi is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9240863 - Flags: data-review?(chutten) → data-review+

This patch adds a crash annotation UserInteractionActive indicating whether
the user interaction state is active or not.

Attachment #9240863 - Attachment is obsolete: true
Attached file data-review-request-bug-1729918-v2 (deleted) —

@Chutten Can you please review the updated data request? The content is almost the same as the previous one except we'll collect an integer instead of a boolean (Question 5).

Attachment #9243664 - Flags: data-review?(chutten)

Comment on attachment 9243664 [details]
data-review-request-bug-1729918-v2

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Toshihito Kikuchi is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 2, Interaction.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.


Result: datareview+

Attachment #9243664 - Flags: data-review?(chutten) → data-review+
Pushed by tkikuchi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cda6b6fe842a Annotate the user interaction state. r=haik

Backed out changeset cda6b6fe842a (Bug 1729918) for causing buid bustages.
Backout link
Push with failures
Failure Log

Flags: needinfo?(tkikuchi)
Pushed by tkikuchi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/656210ea1124 Annotate the user interaction state. r=haik
Backout by nbeleuzu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8f3b0585d1c0 Backed out changeset 656210ea1124 for Bp-hybrid bustages on AvailableMemoryWatcher.cpp . CLOSED TREE
Pushed by tkikuchi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c84f40112a5 Annotate the user interaction state. r=haik
Flags: needinfo?(tkikuchi)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

The query and the report showed more than 90% of crashes occurred while users were active (= the last inactive duration was less than 10 seconds). With this data, we don't need to change the current polling policy: We pause the timer to monitor memory status while the user is inactive.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: