Closed
Bug 1730086
Opened 3 years ago
Closed 3 years ago
TextLeafPoint: Implement HyperTextAccessible::TextBefore/AfterOffset using TextLeafPoint
Categories
(Core :: Disability Access APIs, task)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
98 Branch
Tracking | Status | |
---|---|---|
firefox98 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
(Blocks 1 open bug)
Details
(Whiteboard: [ctw-m1])
Attachments
(4 files)
In bug 1729407, code was added to HyperTextAccessible::TextAtOffset to use TextLeafPoint. We also need code that can use TextLeafPoint for TextBeforeOffset and TextAfterOffset.
Assignee | ||
Updated•3 years ago
|
Blocks: a11y-ctw-text
Assignee | ||
Updated•3 years ago
|
Whiteboard: [ctw-m1]
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → jteh
Assignee | ||
Comment 1•3 years ago
|
||
As with TextAtOffset, the local HyperTextAccessible methods use the base implementation when the cache is enabled.
Assignee | ||
Comment 2•3 years ago
|
||
This was due to a bug in TextLeafPoint::FindPrevWordStartSameAcc which hasn't been exposed before now.
Assignee | ||
Comment 3•3 years ago
|
||
Assignee | ||
Comment 4•3 years ago
|
||
Pushed by jteh@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/23d41a667bc1
part 1: Implement HyperTextAccessibleBase::TextBefore/AfterOffset using TextLeafPoint. r=morgan
https://hg.mozilla.org/integration/autoland/rev/6d9cfbb51c7a
part 2: Fix HyperTextAccessibleBase::TextBeforeOffset when called just after two consecutive line feeds. r=morgan
https://hg.mozilla.org/integration/autoland/rev/f9136c2f4cd0
part 3: Rename RemoteAccessible::GetTextBefore/AfterOffset to TextBefore/AfterOffset, have it override HyperTextAccessibleBase and use the base methods in ATK/XPCOM. r=morgan
https://hg.mozilla.org/integration/autoland/rev/98bebfa0d73b
part 4: Support IAccessibleText::textBefore/AfterOffset for cached RemoteAccessibles. r=morgan
Comment 6•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/23d41a667bc1
https://hg.mozilla.org/mozilla-central/rev/6d9cfbb51c7a
https://hg.mozilla.org/mozilla-central/rev/f9136c2f4cd0
https://hg.mozilla.org/mozilla-central/rev/98bebfa0d73b
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox98:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 98 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•